Fix autocorrect onChangeText firing (#22691) by ericlewis · Pull Request #23666 · react/react-native

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

ericlewis · 2019-02-27T04:11:44Z

Summary

This fixes an issue where autocorrect changes may cause onChangeText to not fire. It subscribes to the underlying textStorage of the UITextView. It is possible this fixes a few other issues, due to the nature of listening to the underlying textStorage changes.

Changelog

[iOS] [Fixed] - iOS firing onChangeText when choosing autocorrect options

Test Plan

Open RNTester, and interact with textfields.

ericlewis · 2019-02-27T04:12:07Z

fixes #22691

ericlewis · 2019-02-27T09:19:07Z

Would appreciate some extra eyes on this, it appears to work, though.

shergin · 2019-02-28T16:07:17Z

cc @rigdern, @mandrigin

That's really cool. I didn't know that the API that we use here exists! That also probably can help us to fix other Korean/Japanese/Chinese issues.

I will test it and hopefully land soon.

shergin · 2019-02-28T16:10:40Z

+ didProcessEditing:(__unused NSTextStorageEditActions)editedMask
+ range:(__unused NSRange)editedRange
+ changeInLength:(__unused NSInteger)delta {
+ [_backedTextInputView.textInputDelegate textInputDidChange];


I am worried a bit about over-firing. So, e.g. if only text attributes were changed, we don't want to send an event.

I will check if this is the case & fix it if that does occur.

facebook-github-bot

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This reverts commit 9bfa4fa.

ericlewis · 2019-02-28T18:27:09Z

@shergin I changed this PR- I originally removed code from the UITextField adapter implementation, this was a mistake I believe. So, listening to the NSTextStorage only applies to multiline TextInput components. I feel like it would make sense for us to use UITextView instead of UITextField for all TextInput's due to UITextView having lower level API access.

zhongwuzw

Give some my opinions:

- textStorage:didProcessEditing:range:changeInLength: delegate would not be called, we should set textStorage.delegate to adapter.
textStorage is created and managed by UITextView, so is it really safe to change the delegate?
- textStorage:didProcessEditing:range:changeInLength: would be called when text attributes changed, I think it may not what we want.
- textStorage:didProcessEditing:range:changeInLength: would always be called, for example, we set defaultValue props for initial value, it should't be called onChange.
If all things above fixes, singleline textinput still has issues. Because this PR try to fix multiline textinput.

ericlewis · 2019-03-01T01:26:58Z

@zhongwuzw ah yes, I forgot to set the delegate in my cleaned up version. I will fix that. Good point on the remaining issues.

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Fix autocorrect onChangeText firing (react#22691)
9bfa4fa

ericlewis added Platform: iOS iOS applications. Component: TextInput Related to the TextInput component. labels Feb 27, 2019

ericlewis self-assigned this Feb 27, 2019

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2019

react-native-bot added the PR: Includes Changelog label Feb 27, 2019

ericlewis requested a review from shergin February 27, 2019 04:32

shergin reviewed Feb 28, 2019
View reviewed changes

ericlewis mentioned this pull request Feb 28, 2019
[iOS] Fixed onChange prop of textinput not be called in some cases #23687
Closed

facebook-github-bot reviewed Feb 28, 2019
View reviewed changes

ericlewis added 2 commits February 28, 2019 13:20

Revert "Fix autocorrect onChangeText firing (react#22691)"
3a66142
This reverts commit 9bfa4fa.

Clean-up
ff110f9

zhongwuzw suggested changes Mar 1, 2019
View reviewed changes

ericlewis closed this Mar 4, 2019

facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024

Uh oh!

Conversation

ericlewis commented Feb 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

ericlewis commented Feb 27, 2019

Uh oh!

ericlewis commented Feb 27, 2019

Uh oh!

shergin commented Feb 28, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

ericlewis commented Feb 28, 2019

Uh oh!

zhongwuzw left a comment

Choose a reason for hiding this comment

Uh oh!

ericlewis commented Mar 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ericlewis commented Feb 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

ericlewis commented Feb 27, 2019

Uh oh!

ericlewis commented Feb 27, 2019

Uh oh!

shergin commented Feb 28, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

ericlewis commented Feb 28, 2019

Uh oh!

zhongwuzw left a comment

Choose a reason for hiding this comment

Uh oh!

ericlewis commented Mar 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ericlewis commented Feb 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

ericlewis commented Feb 27, 2019•
edited
Loading

ericlewis commented Feb 27, 2019•
edited
Loading

ericlewis commented Feb 27, 2019•
edited
Loading

ericlewis commented Feb 27, 2019•
edited
Loading