[iOS] Fixed onChange prop of textinput not be called in some cases

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).

[zhongwuzw]

Summary

TextInput not call onChange prop in some cases, the reason is textInputDidChange is not be called, for example select some text and click the text in keyboard predictive text.

I have the PR#23472 , it fix the correction of _predictedText, I think we need to fix that firstly 😂 .

Changelog

[iOS] [Fixed] - Fixed onChange prop of textinput not be called in some cases

Test Plan

onChange prop can be called when text changed.

[ericlewis]

I think this is a duplicate of #23666, interesting way to solve it though!

[zhongwuzw]

@ericlewis Oops, I'll see your PR. 😂

[ericlewis]

@zhongwuzw my solution is only for multi line text inputs :(

[zhongwuzw]

@ericlewis I give some my opinions in your PR, please check that! ❤️

[zhongwuzw]

Seems #23666 has been closed by @ericlewis , so we can review this implementation? 🤔

[zhongwuzw]

CC. @cpojer@shergin Needs some guy to review. 😂

[shergin]

The whole point to have those adapters is to call onChange only inside textInputDidChange, so all trickiness must be consolidated there.

[zhongwuzw]

@shergin How about this way, to fix textInputDidChange not be called in some cases, we do it by ourself.

[shergin]

Well, using performSelector:withObject:afterDelay: makes this fix unreliable.

[shergin]

Feel free to open a new one or reopen this one once we have a proper reliable fix for that,

[zhongwuzw]

After some try, I think f032e7a is more suitable to solve this issue.

[zhongwuzw]

@shergin Hi :) , the reason I reopened is I think onChangeText may a common event for TextInput, can we fix it firstly? maybe we can optimize it later if anyone can find the better solution.

[shergin]

I am not comfortable with calling onChange inside textInputShouldChangeTextInRange.

As I said previously, all quicky behavior should be implemented in delegate adapter classes.
I do want to fix this issue very very badly but we cannot sacrifice maintainability of the code for this (so we need to improve the quality of this to make it merged).