Skip to content

Move utilities out of react_native_pods - Part 2 - #33982

Closed
cipolleschi wants to merge 2 commits into
react:mainfrom
cipolleschi:export-D37006265
Closed

Move utilities out of react_native_pods - Part 2#33982
cipolleschi wants to merge 2 commits into
react:mainfrom
cipolleschi:export-D37006265

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

Summary:
This Diff moves another part of the utilities from the react_native_pods file to a specific utils.rb file.

It adds tests for these utils and improve our test mocks.

The goal is to simplify the react_native_pods.rb so it's easier to work with it.

I decided to split this diff in 2 because it was becoming quite big.

Changelog

[iOS][Changed] - Refactoring part of the react_native_pods.rb script

Differential Revision: D37006265

Riccardo Cipolleschi added 2 commits June 9, 2022 06:56
Summary:
Pull Request resolved: #33978
This Diff moves part of the utilities from the `react_native_pods` file to a specific `utils.rb` file.
It adds tests for these utils and improve our test mocks.
The goal is to simplify the `react_native_pods.rb` so it's easier to work with it.
I decided to split this diff in 2 because it was becoming quite big.
## Changelog
[iOS][Changed] - Refactoring part of the react_native_pods.rb script
Differential Revision: D37004347
fbshipit-source-id: ecc1b1cb0825440e9e5ae5a92846bc8fe8602d99
Summary:
This Diff moves another part of the utilities from the `react_native_pods` file to a specific `utils.rb` file.
It adds tests for these utils and improve our test mocks.
The goal is to simplify the `react_native_pods.rb` so it's easier to work with it.
I decided to split this diff in 2 because it was becoming quite big.
## Changelog
[iOS][Changed] - Refactoring part of the react_native_pods.rb script
Differential Revision: D37006265
fbshipit-source-id: 580152f6f3bc97c78e23d1004695c60a718c875c
@cipolleschi
cipolleschi requested a review from hramos as a code ownerJune 9, 2022 13:58
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 9, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D37006265

@pull-bot

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 41534d8

@react-native-botreact-native-bot added the Platform: iOS iOS applications. label Jun 9, 2022
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,782,640+0
androidhermesarmeabi-v7a7,172,350+0
androidhermesx868,093,283+0
androidhermesx86_648,069,317+0
androidjscarm64-v8a9,649,489+0
androidjscarmeabi-v7a8,408,181+0
androidjscx869,600,998+0
androidjscx86_6410,194,061+0

Base commit: a0e6ffe
Branch: main

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: a0e6ffe
Branch: main

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cipolleschi in 4f732ba.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Jun 10, 2022
@cortinicocortinico mentioned this pull request Jun 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartnerPlatform: iOSiOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cipolleschi@facebook-github-bot@pull-bot@analysis-bot@react-native-bot