Skip to content

feat: added enterKeyHint prop to textInput - #34482

Closed
dakshbhardwaj wants to merge 2 commits into
react:mainfrom
dakshbhardwaj:feat/add-enter-key-hint-to-text-input
Closed

feat: added enterKeyHint prop to textInput#34482
dakshbhardwaj wants to merge 2 commits into
react:mainfrom
dakshbhardwaj:feat/add-enter-key-hint-to-text-input

Conversation

@dakshbhardwaj

Copy link
Copy Markdown
Contributor

Summary

This adds the enterKeyHint prop to the TextInput component as requested on #34424, mapping web enterKeyHint types to equivalent returnKeyType values. This PR also updates RNTester TextInputExample in order to facilitate the manual QA.

Open questions

  • What should be the returnType in the case of previous in iOS?

  • what should happen if enterKeyHint and returnKeyType props are passed together?

Changelog

[General] [Added] - Add enterKeyHint prop to TextInput component

Test Plan

  • Open the RNTester app and navigate to the TextInput page
  • Test the TextInput component through the enterKeyHint modes section

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @dakshbhardwaj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-botreact-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 23, 2022
@analysis-bot

analysis-bot commented Aug 23, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,617,378+209
androidhermesarmeabi-v7a7,031,726+214
androidhermesx867,917,537+203
androidhermesx86_647,891,228+204
androidjscarm64-v8a9,495,010+140
androidjscarmeabi-v7a8,272,719+134
androidjscx869,432,897+137
androidjscx86_6410,025,943+134

Base commit: de75a7a
Branch: main

@dakshbhardwaj
dakshbhardwaj marked this pull request as ready for review August 23, 2022 15:26
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 23, 2022
@necolas

Copy link
Copy Markdown

Any idea why some of the iOS CI jobs failed? Flakey?

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: de75a7a
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@dakshbhardwaj

dakshbhardwaj commented Aug 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@necolas Thanks for reviewing and approving it. do I need to do anything else?

@necolas

Copy link
Copy Markdown

No, just waiting on someone to do an internal review. Thanks

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @dakshbhardwaj in 8c882b4.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Aug 30, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 5, 2023
Summary:
Resolves: #37622
Related:
#34482https://reactnative.dev/docs/textinput#enterkeyhint
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Added]: Add enterKeyHint in TextInput type declaration
Pull Request resolved: #37624
Reviewed By: cortinico, NickGerleman
Differential Revision: D46292040
Pulled By: lunaleaps
fbshipit-source-id: a037b7f8dd0d60880dcf1aec64749546fa54a95d
lunaleaps pushed a commit that referenced this pull request Aug 7, 2023
Summary:
Resolves: #37622
Related:
#34482https://reactnative.dev/docs/textinput#enterkeyhint
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Added]: Add enterKeyHint in TextInput type declaration
Pull Request resolved: #37624
Reviewed By: cortinico, NickGerleman
Differential Revision: D46292040
Pulled By: lunaleaps
fbshipit-source-id: a037b7f8dd0d60880dcf1aec64749546fa54a95d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Type: EnhancementA new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dakshbhardwaj@facebook-github-bot@analysis-bot@necolas@react-native-bot