Skip to content

Add enterKeyHint in TextInput type declaration - #37624

Closed
tarunrajput wants to merge 1 commit into
react:mainfrom
tarunrajput:add-TextInput-enterKeyHint-missing-declaration-types
Closed

Add enterKeyHint in TextInput type declaration#37624
tarunrajput wants to merge 1 commit into
react:mainfrom
tarunrajput:add-TextInput-enterKeyHint-missing-declaration-types

Conversation

@tarunrajput

@tarunrajputtarunrajput commented May 30, 2023

Copy link
Copy Markdown
Contributor

Summary:

Resolves: #37622

Related:
#34482
https://reactnative.dev/docs/textinput#enterkeyhint

Changelog:

[Internal][Added]: Add enterKeyHint in TextInput type declaration

Test Plan:

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2023
@analysis-bot

analysis-bot commented May 30, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,744,596+4
androidhermesarmeabi-v7a8,056,237+4
androidhermesx869,235,405+4
androidhermesx86_649,086,283+4
androidjscarm64-v8a9,307,301+2
androidjscarmeabi-v7a8,496,538+5
androidjscx869,369,188+4
androidjscx86_649,624,180+3

Base commit: 7f22db8
Branch: main

@tarunrajput
tarunrajputforce-pushed the add-TextInput-enterKeyHint-missing-declaration-types branch from de7e0f1 to 73d6657CompareMay 30, 2023 18:32
@tarunrajput
tarunrajput marked this pull request as ready for review May 30, 2023 18:33
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tarunrajput

Copy link
Copy Markdown
ContributorAuthor

Updated docs as well to add missing go value and mark enter as iOS only
PR: react/react-native-website#3739

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Jun 5, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@lunaleaps merged this pull request in 5062553.

@tarunrajput
tarunrajput deleted the add-TextInput-enterKeyHint-missing-declaration-types branch June 27, 2023 11:13
lunaleaps pushed a commit that referenced this pull request Aug 7, 2023
Summary:
Resolves: #37622
Related:
#34482https://reactnative.dev/docs/textinput#enterkeyhint
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Added]: Add enterKeyHint in TextInput type declaration
Pull Request resolved: #37624
Reviewed By: cortinico, NickGerleman
Differential Revision: D46292040
Pulled By: lunaleaps
fbshipit-source-id: a037b7f8dd0d60880dcf1aec64749546fa54a95d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enterKeyHint is missing from TextInputProps type

3 participants

@tarunrajput@analysis-bot@facebook-github-bot