Uh oh!
There was an error while loading. Please reload this page.
eslint config & plugin packages - prep for monorepo RFC - #34581
Conversation
afoxman
commented
Sep 2, 2022
cc @cortinico Monorepo PR |
afoxman
commented
Sep 2, 2022
There are some errors from CircleCI about the new packages not being in NPM yet they are referenced as dependencies in the old packages. If you'd like, I can split this up so the new packages are published first, then land that, and make a 2nd PR to update the old packages, making them point to the new ones. I didn't do that initially because I know this is going to cause a lot of internal work, and I thought 2 PRs might increase that workload. |
Base commit: e680018 |
Base commit: e680018 |
afoxman
commented
Sep 9, 2022
cc @cipolleschi for tracking |
cortinico
commented
Sep 15, 2022
Hey @afoxman I've posted an update on the Monorepo effort here: I'm not entirely sure how we want to handle this (@kelset has a stronger opinion I believe). I believe we probably don't want to keep wrapper packages for the older package names (it would be quite of an overkill, as we'll have to do it for all the packages). I would suggest we downscale the PR to just renaming + bumping the packages. |
hoxyq
commented
Nov 10, 2022
afoxman
commented
Nov 10, 2022
Hi @hoxyq, definitely! Thank you for picking this up for me and pushing the monorepo forward. |
facebook-github-bot
commented
Nov 23, 2022
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pull-bot
commented
Nov 24, 2022
PR build artifact for 7972310639a223451586a22d76792d92fe1e08b2 is ready. |
pull-bot
commented
Nov 24, 2022
PR build artifact for 7972310639a223451586a22d76792d92fe1e08b2 is ready. |
facebook-github-bot
commented
Nov 24, 2022
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pull-bot
commented
Nov 24, 2022
PR build artifact for c657aad8341562187d01ec810696005f68ab178d is ready. |
pull-bot
commented
Nov 24, 2022
PR build artifact for c657aad8341562187d01ec810696005f68ab178d is ready. |
…ch the rest of the repo.
pull-bot
commented
Nov 25, 2022
PR build artifact for 2915e79 is ready. |
pull-bot
commented
Nov 25, 2022
PR build artifact for 2915e79 is ready. |
facebook-github-bot
commented
Nov 25, 2022
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Nov 25, 2022
This pull request was successfully merged by @afoxman in 5aead70. When will my fix make it into a release? | Upcoming Releases |
mm-webx
commented
Dec 1, 2022
Its not working:
|
@mm-webx I don't think it's expected to work yet, these new versions still need to be published. It will take time, for now you are not supposed to migrate to it. (0.71 will not use these new versions) |
hoxyq
commented
Dec 1, 2022
Hey @mm-webx, @kelset is correct, before we publish this package you can use |
### Summary Fixes#443 Replaced `@react-native-community/eslint-config` with `@react-native/eslint-config`. Please see the PR that changes the name on the React Native repository [here](react/react-native#34581) ### Test plan 1. Create a new React Native library 2. cd into the library you have created. 3. run `yarn lint` 4. Make sure linting works properly.
Summary
The monorepo RFC calls for renaming:
@react-native-community/eslint-config->@react-native/eslint-config@react-native-community/eslint-plugin->@react-native/eslint-pluginIt also calls for the versions to be aligned with the rest of main -- currently
0.72.0.Changelog
[General][Changed] - Renamed
@react-native-community/eslint-configto@react-native/eslint-configv0.72.0 to align with other packages[General][Changed] - Renamed
@react-native-community/eslint-pluginto@react-native/eslint-pluginv0.72.0 to align with other packagesTest Plan
First test is to run
yarn lint, and verify that output matches before and after this change.Second test is to change the ESLint config to use the "old" packages (under
@react-native-commnuity) and runyarn lintto make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages.