Uh oh!
There was an error while loading. Please reload this page.
eslint config & plugin packages - prep for monorepo RFC (#34581) - #35448
Closed
hoxyq wants to merge 2 commits into
Closed
eslint config & plugin packages - prep for monorepo RFC (#34581)#35448hoxyq wants to merge 2 commits into
hoxyq wants to merge 2 commits into
Conversation
…before testing template app (#35444) Summary: Pull Request resolved: #35444 Changelog: [Internal][Changed] - now using Verdaccio to publish necessary packages for template app - Adds script `/scripts/template/install-dependencies.js`, which incapsulates the logic of installing dependencies of template app - The idea of the script is to run verdaccio and publish all necessary packages to node_modules, since these packages might not yet be present on npm - This should also potentially resolve some template app test failures on CircleCI related to package-ifying Animated, VirtualizedList, FlatList modules Differential Revision: https://internalfb.com/D41498086 fbshipit-source-id: 6d5a3d4bb155ca22fcf41190992cc6679971d5d2
Summary: The [monorepo RFC](react-native-community/discussions-and-proposals#480) calls for renaming: * `react-native-community/eslint-config` -> `react-native/eslint-config` * `react-native-community/eslint-plugin` -> `react-native/eslint-plugin` It also calls for the versions to be aligned with the rest of main -- currently `0.71.0`. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> General Added - Added a new package `react-native/eslint-config` and migrated ESLint configuration into it from `react-native-community/eslint-config` General Added - Added a new package `react-native/eslint-plugin` and migrated ESLint plugins into it from `react-native-community/eslint-plugin` General Changed - Migrated contents of `react-native-community/eslint-config` into `react-native/eslint-config` General Changed - Migrated contents of `react-native-community/eslint-plugin` into `react-native/eslint-plugin` Pull Request resolved: #34581 Test Plan: First test is to run `yarn lint`, and verify that output matches before and after this change. Second test is to change the ESLint config to use the "old" packages (under `react-native-commnuity`) and run `yarn lint` to make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages. Differential Revision: D41495332 Pulled By: hoxyq fbshipit-source-id: 36e756333ab0711927927c18af736c0931dbf9b4
facebook-github-bot
commented
Nov 23, 2022
Contributor
This pull request was exported from Phabricator. Differential Revision: D41495332 |
|
analysis-bot
commented
Nov 23, 2022
Base commit: c5a8425 |
analysis-bot
commented
Nov 23, 2022
Base commit: c5a8425 |
pull-bot
commented
Nov 23, 2022
PR build artifact for b656fbc is ready. |
pull-bot
commented
Nov 23, 2022
PR build artifact for b656fbc is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The monorepo RFC calls for renaming:
react-native-community/eslint-config->react-native/eslint-configreact-native-community/eslint-plugin->react-native/eslint-pluginIt also calls for the versions to be aligned with the rest of main -- currently
0.71.0.Changelog
General Added - Added a new package
react-native/eslint-configand migrated ESLint configuration into it fromreact-native-community/eslint-configGeneral Added - Added a new package
react-native/eslint-pluginand migrated ESLint plugins into it fromreact-native-community/eslint-pluginGeneral Changed - Migrated contents of
react-native-community/eslint-configintoreact-native/eslint-configGeneral Changed - Migrated contents of
react-native-community/eslint-pluginintoreact-native/eslint-pluginPull Request resolved: #34581
Test Plan:
First test is to run
yarn lint, and verify that output matches before and after this change.Second test is to change the ESLint config to use the "old" packages (under
react-native-commnuity) and runyarn lintto make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages.Differential Revision: D41495332
Pulled By: hoxyq