Uh oh!
There was an error while loading. Please reload this page.
Extract the UnsupportedArrayElementTypeAnnotationParserError in its o… - #35167
Conversation
|
Base commit: 850f855 |
Base commit: 850f855 |
pull-bot
commented
Nov 2, 2022
PR build artifact for 40fa9cdb8540ba6a928d8a944f85b9d200333f27 is ready. |
facebook-github-bot
commented
Nov 2, 2022
Hi @matiassalles99! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
commented
Nov 2, 2022
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
pull-bot
commented
Nov 2, 2022
PR build artifact for 8aa0e5d6211a9e4ceaaa0abbd9566701ffccc985 is ready. |
pull-bot
commented
Nov 2, 2022
PR build artifact for 5df9d384fcb337b409324ba82bf4576dc30b5c3a is ready. |
pull-bot
commented
Nov 2, 2022
PR build artifact for 484a82789050707a5547ed64c1c043e819251230 is ready. |
rshest
commented
Nov 2, 2022
Please check the output from failed CircleCI tests, there is at least one that I can see may be relevant (analyze_code/Check Formatting). |
pull-bot
commented
Nov 2, 2022
PR build artifact for cfa262d4131c1bd83439ba47e1b6fc13d4b1aeb9 is ready. |
rshest
commented
Nov 2, 2022
There is also |
Uh oh!
There was an error while loading. Please reload this page.
rshest
left a comment
There was a problem hiding this comment.
Hey @matiassalles99 , just sending it back to you for posterity, to do the changes as agreed above.
cipolleschi
commented
Nov 10, 2022
@matiassalles99, could you please rebase onto main and take care of the conflicts? Thank you so much! 🙏 |
gabrieldonadel
commented
Nov 18, 2022
any updates on this? |
matiassalles99
commented
Nov 18, 2022
Yes im going to tackle it tomorrow, sorry for the late reply I didn't have much time lately |
rshest
left a comment
There was a problem hiding this comment.
Looks good! Please do make sure that merge conflicts vs the trunk are resolved.
facebook-github-bot
commented
Nov 21, 2022
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pull-bot
commented
Nov 21, 2022
PR build artifact for 63df7a7e062eefdfb963111a1b1e8a8a17adaced is ready. |
63df7a7 to
7240471Comparematiassalles99
commented
Nov 21, 2022
@rshest Just fixed conflicts |
pull-bot
commented
Nov 21, 2022
PR build artifact for 7240471 is ready. |
Summary
This PR is part of #34872
This PR extracts the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function.
Changelog
[Internal] [Changed] - Extract the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function
Test Plan