Skip to content

Extract the UnsupportedArrayElementTypeAnnotationParserError in its o… - #35167

Closed
matiassalles99 wants to merge 7 commits into
react:mainfrom
matiassalles99:chore/extract-unsupported-array-element-type-annotation-parser-error
Closed

Extract the UnsupportedArrayElementTypeAnnotationParserError in its o…#35167
matiassalles99 wants to merge 7 commits into
react:mainfrom
matiassalles99:chore/extract-unsupported-array-element-type-annotation-parser-error

Conversation

@matiassalles99

@matiassalles99matiassalles99 commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Summary

This PR is part of #34872
This PR extracts the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function.

Changelog

[Internal] [Changed] - Extract the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function

Test Plan

Screen Shot 2022-11-02 at 15 21 15

@github-actions

github-actionsBot commented Nov 2, 2022

Copy link
Copy Markdown
Warnings
⚠️

packages/react-native-codegen/src/parsers/typescript/modules/index.js#L16 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 16 – 'NativeModuleArrayTypeAnnotation' is defined but never used. (no-unused-vars)

⚠️

packages/react-native-codegen/src/parsers/typescript/modules/index.js#L58 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 58 – 'UnsupportedArrayElementTypeAnnotationParserError' is assigned a value but never used. (no-unused-vars)

⚠️

packages/react-native-codegen/src/parsers/typescript/modules/index.js#L59 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 59 – 'UnnamedFunctionParamParserError' is assigned a value but never used. (no-unused-vars)

⚠️

packages/react-native-codegen/src/parsers/typescript/modules/index.js#L74 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 74 – 'throwIfUnsupportedFunctionReturnTypeAnnotationParserError' is assigned a value but never used. (no-unused-vars)

Generated by 🚫 dangerJS against 7240471

@analysis-bot

analysis-bot commented Nov 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,102,440+0
androidhermesarmeabi-v7a6,470,493+0
androidhermesx867,519,895+0
androidhermesx86_647,378,573+0
androidjscarm64-v8a8,967,309+0
androidjscarmeabi-v7a7,698,152+0
androidjscx869,029,418+0
androidjscx86_649,507,263+0

Base commit: 850f855
Branch: main

@analysis-bot

analysis-bot commented Nov 2, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 850f855
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for 40fa9cdb8540ba6a928d8a944f85b9d200333f27 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @matiassalles99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2022
@pull-bot

Copy link
Copy Markdown

PR build artifact for 8aa0e5d6211a9e4ceaaa0abbd9566701ffccc985 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 5df9d384fcb337b409324ba82bf4576dc30b5c3a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@matiassalles99
matiassalles99 marked this pull request as ready for review November 2, 2022 19:23
@pull-bot

Copy link
Copy Markdown

PR build artifact for 484a82789050707a5547ed64c1c043e819251230 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@rshest

Copy link
Copy Markdown
Contributor

Please check the output from failed CircleCI tests, there is at least one that I can see may be relevant (analyze_code/Check Formatting).

@pull-bot

Copy link
Copy Markdown

PR build artifact for cfa262d4131c1bd83439ba47e1b6fc13d4b1aeb9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@rshest

Copy link
Copy Markdown
Contributor

There is also NativeModuleArrayTypeAnnotation that is still imported, but all the usages were removed in your diff :)

Comment threadpackages/react-native-codegen/src/parsers/error-utils.js Outdated

@rshestrshest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matiassalles99 , just sending it back to you for posterity, to do the changes as agreed above.

@cipolleschi

Copy link
Copy Markdown
Contributor

@matiassalles99, could you please rebase onto main and take care of the conflicts? Thank you so much! 🙏

@gabrieldonadel

Copy link
Copy Markdown
Collaborator

any updates on this?

@matiassalles99

Copy link
Copy Markdown
ContributorAuthor

Yes im going to tackle it tomorrow, sorry for the late reply I didn't have much time lately

@rshestrshest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please do make sure that merge conflicts vs the trunk are resolved.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pull-bot

Copy link
Copy Markdown

PR build artifact for 63df7a7e062eefdfb963111a1b1e8a8a17adaced is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@matiassalles99
matiassalles99force-pushed the chore/extract-unsupported-array-element-type-annotation-parser-error branch from 63df7a7 to 7240471CompareNovember 21, 2022 17:02
@matiassalles99

Copy link
Copy Markdown
ContributorAuthor

@rshest Just fixed conflicts

@pull-bot

Copy link
Copy Markdown

PR build artifact for 7240471 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@matiassalles99@analysis-bot@pull-bot@facebook-github-bot@rshest@cipolleschi@gabrieldonadel