Uh oh!
There was an error while loading. Please reload this page.
[Codegen]: Refactor translateArrayTypeAnnotation fns of (Flow, TS) > common fn > parsers-primitives.js - #35326
Closed
Pranav-yadav wants to merge 1 commit into
Closed
Conversation
- combined `Flow` and `TS` `translateArrayTypeAnnotation` fn 's into common fn - moved it to `parsers-primitives.js` - re-organized imports and exports Extras: - resolved conflicts :) Temp: [skip ci]
Pranav-yadav
commented
Nov 13, 2022
ContributorAuthor
Depends on PR #35167 :) |
Pranav-yadavforce-pushed
the
rf/translateArrayTypeAnnotation
branch
from
November 13, 2022 16:01
4eb5fc5 to
67ce2f2ComparePranav-yadav
commented
Nov 14, 2022
ContributorAuthor
Didn't see a 👍, before opening the PR.. It was like chore to open PR (daily routine). Sorry :) |
Pranav-yadav
commented
Nov 25, 2022
ContributorAuthor
Reopened here #35479:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlowandTStranslateArrayTypeAnnotationfn 's into common fnparsers-primitives.jsExtras:
[skip ci]
Changelog
[INTERNAL] [CHANGED] - [Codegen]: Refactored
translateArrayTypeAnnotationfns of (Flow, TS) > common fn >parsers-primitives.jsTest Plan