fix: pod install with --project-directory

[dcangulo]

Summary

The variable version is previously used but in 2344860#diff-adcf572f001c2b710d14f409c14763f1a50b08369b3034548f1602685d21f67f, its usage have been removed the but the variable is kept.

It also raises an error when using bundle exec pod install --project-directory=ios which works on 0.70.X and below.

No such file or directory @ rb_sysopen - ../node_modules/react-native/package.json
/Users/davidangulo/Desktop/mobile/myapp/node_modules/react-native/scripts/react_native_pods.rb:212:in `read'
/Users/davidangulo/Desktop/mobile/myapp/node_modules/react-native/scripts/react_native_pods.rb:212:in `react_native_post_install'

Changelog

[IOS] [FIXED] - pod install with --project-directory

Test Plan

bundle exec pod install --project-directory=ios should not raise an error.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,493,253	+0
android	hermes	armeabi-v7a	7,813,845	+0
android	hermes	x86	8,969,058	+0
android	hermes	x86_64	8,827,238	+0
android	jsc	arm64-v8a	9,678,873	+0
android	jsc	armeabi-v7a	8,413,102	+0
android	jsc	x86	9,743,267	+0
android	jsc	x86_64	10,220,680	+0

Base commit: 4923a09
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 4923a09
Branch: main

[pull-bot]

PR build artifact for e93b7e9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for e93b7e9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[rshest]

CC @dmytrorykun to double check.

[facebook-github-bot]

@rshest merged this pull request in efd39ee.

[arnaudambro]

@dcangulo I have the exact same error with pod install with --project-directory

but when I go into the ./ios folder and pod install, no problem

[dcangulo]

@arnaudambro This issue should be fixed in 0.72.

For 0.71, you can do the following for a workaround.

post_install do |installer|
react_native_post_install(
installer,
+ 'node_modules/react-native',
# Set `mac_catalyst_enabled` to `true` in order to apply patches
# necessary for Mac Catalyst builds
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end

In your ios/Podfile.

[marcoj]

@arnaudambro This issue should be fixed in 0.72.

For 0.71, you can do the following for a workaround.

post_install do |installer|
react_native_post_install(
installer,
+ 'node_modules/react-native',
# Set `mac_catalyst_enabled` to `true` in order to apply patches
# necessary for Mac Catalyst builds
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end

In your ios/Podfile.

I'm using a monorepo and this worked perfectly, just needed to add the correct path. in my case: '../../../node_modules/react-native',

Thank!

[varemenos]

Doesn't this fix qualify for a 0.71.X cherry pick? Seems like it's worth including instead of waiting for another minor version release (0.72).

[dcangulo]

@varemenos#36096 would fix it for 0.71.X