Uh oh!
There was an error while loading. Please reload this page.
ci: use pod install --project-directory when testing template - #37996
ci: use pod install --project-directory when testing template#37996tido64 wants to merge 1 commit into
pod install --project-directory when testing template#37996Conversation
09ed06e to
62ad520Compare
Base commit: eaafc26 |
tido64
commented
Jun 21, 2023
Seems to be failing as expected: I'll rebase when #37992 lands. |
62ad520 to
09044fcComparefacebook-github-bot
commented
Jun 23, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
left a comment
There was a problem hiding this comment.
doing this will run the pod install command for ALL the template tests from the parent directory.
Could there be a scenario where this works but running pod install from the ios folder (i.e.: without the --project-directory parameter) fails?
In other words, if we proceed with this, could we end up breaking pod install from ios?
My gut says no, as using --project-directory seems like a more general case than running pod install from a specific folder, but I think it's worth double-checking.
cipolleschi
commented
Jun 26, 2023
(requesting change to discuss the point above, mainly) |
cipolleschi
commented
Jun 26, 2023
/rebase |
09044fc to
6b938c7Comparetido64
commented
Jun 26, 2023
I haven't run through all possible cases, but for what it's worth, we've always used this in RNTA and have not encountered a case where |
cipolleschi
commented
Jun 26, 2023
Yeah, I supposed that that was the case. |
facebook-github-bot
commented
Jun 26, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
commented
Jun 26, 2023
/rebase |
6b938c7 to
2e108c8Comparefacebook-github-bot
commented
Jun 26, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @tido64 in e1fd4a8. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
commented
Jun 26, 2023
@cipolleschi merged this pull request in e1fd4a8. |

Summary:
Exercise
pod install --project-directory=ioswhen building the generated iOS project to make sure we don't regress in the future.See also #37992, #35754, #34215, #33909…
Changelog:
[INTERNAL] [ADDED] - Exercise
pod install --project-directory=ioswhen testing the iOS templateTest Plan:
CI should pass.