chore(babel,flow): realign version bumps by kelset · Pull Request #35787 · react/react-native

kelset · 2023-01-06T11:23:28Z

Summary

While working on #35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape.

Happy to split in multiple PRs if needed.

Changelog

[GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.201 in a few places that were left out from latest bump

Test Plan

CI is green.

facebook-github-bot · 2023-01-06T11:37:46Z

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robhogan · 2023-01-06T11:40:58Z

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime bump is a big one - but I'll see if we can make it stick.

kelset · 2023-01-06T12:03:39Z

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime bump is a big one - but I'll see if we can make it stick.

yeah no worries, I'm happy to split in multiple PRs if needed (in particular the flow aligments and the babel bump in template)

kelset · 2023-01-17T12:11:58Z

@robhogan just wanted to check in how's it going for this PR - as mentioned, I'm happy to split in multiples to get as much of this in as possible right away

kelset · 2023-03-07T10:32:13Z

@robhogan @cipolleschi I just gave another pass and a cleanup to this PR, is it worth keeping open or I should just close it?

analysis-bot · 2023-03-07T10:55:21Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,732,587	+0
android	hermes	armeabi-v7a	8,043,960	-1
android	hermes	x86	9,221,946	-4
android	hermes	x86_64	9,074,944	-2
android	jsc	arm64-v8a	9,297,786	-4
android	jsc	armeabi-v7a	8,486,594	-2
android	jsc	x86	9,358,542	-2
android	jsc	x86_64	9,615,143	+1

Base commit: 0a4a95f
Branch: main

cipolleschi · 2023-03-08T13:33:07Z

I don't know... maybe @robhogan has more info/ideas?

robhogan · 2023-03-08T13:45:59Z

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

hoxyq · 2023-03-08T13:58:58Z

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

Monorepo changes also include bumping yargs outside of react-native, but not in react-native-github/hermes-inspector-msggen. I think we should return to this PR next week, if monorepo won't be landed by this time, we should at least merge this PR to have in 0.72 (as stated in summary)

kelset · 2023-03-08T14:07:25Z

works for me, let's keep this frozen until the monorepo PR is successfully landed 👍 thanks for the update folks

kelset · 2023-03-21T11:46:02Z

allright, branch rebased and updated! lmk what you want to do with it folks 🤗

github-actions · 2023-03-21T11:46:43Z

	Fails
🚫	📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 2693368

cipolleschi · 2023-03-27T10:21:56Z

What's the actionable here, @robhogan @hoxyq? do we need to import and land this?

hoxyq · 2023-05-17T08:30:37Z

@kelset Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

flow realign ts eslint realign yarn lock second yarn lock Revert "ts eslint realign" This reverts commit 3dd4e52. yarn lock another pass of realign

kelset · 2023-05-17T12:53:27Z

@kelset Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

I'm at chainreact - will take a look next week 🤗

hoxyq · 2023-05-17T12:54:20Z

@kelset Lorenzo Sciandra FTE Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?
I'm at chainreact - will take a look next week 🤗

Will take care of it, if you don't mind

kelset · 2023-05-17T12:57:41Z

go for it 👍

facebook-github-bot · 2023-05-17T14:30:49Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-05-17T14:34:42Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: react/react-native#35787 Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 668de2623494b56867c68e9911a276239554411e

Summary: Pull Request resolved: react#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 73bbe08817f89143ca3bad17e37f8922372797ee

Summary: Pull Request resolved: react#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 7bf82121a6cf76c4f65a3680b32bdd8a06538902

Summary: Pull Request resolved: react#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: c3aa02e1f29133b51dd138ec926ef0c73b78cf84

Summary: Pull Request resolved: #987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump X-link: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d

facebook-github-bot · 2023-05-18T21:10:43Z

@hoxyq merged this pull request in f10dd3f.

Summary: X-link: react/metro#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d Original: react/react-native@f10dd3f

Summary: X-link: react/metro#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d Original-Commit: react/react-native@f10dd3f

Summary: X-link: react/metro#987 While working on react/react-native#35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape. Happy to split in multiple PRs if needed. ## Changelog [GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.206.0 in a few places that were left out from latest bump Pull Request resolved: react/react-native#35787 Test Plan: CI is green. Reviewed By: cipolleschi Differential Revision: D42384881 Pulled By: hoxyq fbshipit-source-id: 21fd43391d12722cf707c3cdbbb36f49c036359d

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Jan 6, 2023

cipolleschi approved these changes Jan 6, 2023
View reviewed changes

kelset force-pushed the kelset/realign-babel-and-flow branch 2 times, most recently from a79070d to 2ebee9eCompare March 7, 2023 10:27

kelset requested a review from robhogan March 7, 2023 10:31

kelset force-pushed the kelset/realign-babel-and-flow branch from 2ebee9e to 5e1546eCompare March 21, 2023 11:39

hoxyq mentioned this pull request May 17, 2023
Fix babel-runtime version #37457
Closed

dependencies realignment
4480644
flow realign ts eslint realign yarn lock second yarn lock Revert "ts eslint realign" This reverts commit 3dd4e52. yarn lock another pass of realign

hoxyq force-pushed the kelset/realign-babel-and-flow branch from 267afc8 to c3731dfCompare May 17, 2023 12:50

hoxyq force-pushed the kelset/realign-babel-and-flow branch from c3731df to fec35f3Compare May 17, 2023 14:19

post rebase cleanup
2693368

hoxyq force-pushed the kelset/realign-babel-and-flow branch from fec35f3 to 2693368Compare May 17, 2023 14:33

hoxyq mentioned this pull request May 18, 2023
bump @babel/* packages (#35787) react/metro#987
Closed

facebook-github-bot closed this in f10dd3fMay 18, 2023

facebook-github-bot added the Merged This PR has been merged. label May 18, 2023

hoxyq mentioned this pull request May 19, 2023
backporting babel bumps to 0.72 #37492
Merged

kelset deleted the kelset/realign-babel-and-flow branch May 22, 2023 09:02

Uh oh!

Conversation

kelset commented Jan 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

facebook-github-bot commented Jan 6, 2023

Uh oh!

robhogan commented Jan 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kelset commented Jan 6, 2023

Uh oh!

kelset commented Jan 17, 2023

Uh oh!

kelset commented Mar 7, 2023

Uh oh!

analysis-bot commented Mar 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipolleschi commented Mar 8, 2023

Uh oh!

robhogan commented Mar 8, 2023

Uh oh!

hoxyq commented Mar 8, 2023

Uh oh!

kelset commented Mar 8, 2023

Uh oh!

kelset commented Mar 21, 2023

Uh oh!

github-actionsBot commented Mar 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipolleschi commented Mar 27, 2023

Uh oh!

hoxyq commented May 17, 2023

Uh oh!

kelset commented May 17, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoxyq commented May 17, 2023

Uh oh!

kelset commented May 17, 2023

Uh oh!

facebook-github-bot commented May 17, 2023

Uh oh!

facebook-github-bot commented May 17, 2023

Uh oh!

facebook-github-bot commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kelset commented Jan 6, 2023•
edited
Loading

robhogan commented Jan 6, 2023•
edited
Loading

analysis-bot commented Mar 7, 2023•
edited
Loading

github-actionsBot commented Mar 21, 2023•
edited
Loading

kelset commented May 17, 2023•
edited
Loading