Skip to content

Fix babel-runtime version - #37457

Closed
Kudo wants to merge 1 commit into
react:mainfrom
Kudo:@kudo/rn072/bump-babel-runtime
Closed

Fix babel-runtime version#37457
Kudo wants to merge 1 commit into
react:mainfrom
Kudo:@kudo/rn072/bump-babel-runtime

Conversation

@Kudo

@KudoKudo commented May 17, 2023

Copy link
Copy Markdown
Contributor

Summary:

Inconsistent @babel/runtime version after 0.72.
On 0.71, it was aligned to ^7.20.0
From 0.72, it was downgraded to ^7.12.5
this might be coming from monorepo movement.

Changelog:

[GENERAL] [FIXED] - Aligned @babel/runtime version to ^7.20.0

Test Plan:

ci passed

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels May 17, 2023
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,732,587-2
androidhermesarmeabi-v7a8,043,934+2
androidhermesx869,221,944+1
androidhermesx86_649,074,913+2
androidjscarm64-v8a9,297,788-1
androidjscarmeabi-v7a8,486,556-1
androidjscx869,358,525-2
androidjscx86_649,615,113+0

Base commit: a310217
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hoxyq

Copy link
Copy Markdown
Contributor

This is not related to monorepo work, this is because #35786 was never backported into the main branch.

There was an attempt in #35787, but we completely missed it.

@Kudo

Kudo commented May 17, 2023

Copy link
Copy Markdown
ContributorAuthor

good to know, thanks @hoxyq. i'm closing this pr in favor of #35787

@KudoKudo closed this May 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.p: ExpoPartner: ExpoPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Kudo@analysis-bot@facebook-github-bot@hoxyq