Breaking - Bump minimum Node version from 14 to 16 - #36217

Closed
robhogan wants to merge 2 commits into
react:mainfrom
robhogan:export-D43436883
Closed

Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom
robhogan:export-D43436883

Conversation

@robhogan

@robhoganrobhogan commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

Summary:

Bump minimum Node JS version to 16 via react-native/package.json#engines

In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.

Insert engines into template/package.json

The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.

Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.

Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.

Changelog:

[General][Breaking] Bump minimum Node JS version to 16

Differential Revision: D43436883

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 20, 2023
@facebook-github-bot

facebook-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43436883

@github-actions

github-actionsBot commented Feb 20, 2023•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae

@robhoganrobhogan mentioned this pull request Feb 20, 2023
Merged
robhoganand others added 2 commits February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot

facebook-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D43436883

cortinico
cortinico approved these changes Feb 20, 2023
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3

@robhoganrobhogan mentioned this pull request Feb 20, 2023
Merged
@facebook-github-bot

facebook-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

This pull request has been merged in afc91de.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Feb 20, 2023
@robhogan
robhogan deleted the export-D43436883 branch February 20, 2023 18:19
facebook-github-bot pushed a commit to react/metro that referenced this pull request Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit to react/react-native-website that referenced this pull request Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94 mentioned this pull request Mar 3, 2023
Merged
arushikesarwani94 added a commit to react/react-native-website that referenced this pull request Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq mentioned this pull request Apr 25, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94 mentioned this pull request Jun 9, 2023
Closed
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit to arushikesarwani94/metro that referenced this pull request Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit to react/metro that referenced this pull request Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Breaking - Bump minimum Node version from 14 to 16 - #36217
Closed
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Closed
Breaking - Bump minimum Node version from 14 to 16#36217
robhogan wants to merge 2 commits into
react:mainfrom 
robhogan:export-D43436883
Conversation
@robhogan
@robhoganrobhogan
commented
Feb 20, 2023

Copy link


Copy Markdown

Collaborator
Summary:
Bump minimum Node JS version to 16 via react-native/package.json#engines
In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert engines into template/package.json
The constraint at react-native/package.json#engines ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) yarn start.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of engines below existing package.json fields is consistent with sort-package-json and prettier-package-json - and keeps it out of the way of fields RN developers are likely to be more concerned about.
Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Feb 20, 2023
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
@github-actions
github-actionsBot
commented
Feb 20, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against f40d4ae
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

robhoganand others
added 2 commits
February 20, 2023 05:40
@robhogan@facebook-github-bot
Remove .node-version file from repo root and template
465f427
Differential Revision: D43421085
fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
@robhogan@facebook-github-bot
Breaking - Bump minimum Node version from 14 to 16
f40d4ae
Summary:
## Bump minimum Node JS version to 16 via `react-native/package.json#engines`
In react#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
## Insert `engines` into `template/package.json`
The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`.
Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about.
## Docs PR
react/react-native-website#3580
## Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883
fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D43436883
cortinico
cortinico
approved these changes
Feb 20, 2023
View reviewed changes
@cortinicocortinico
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
@robhoganrobhogan
mentioned this pull request
Feb 20, 2023
 Merged

@facebook-github-bot
facebook-github-bot
commented
Feb 20, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in afc91de.
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Feb 20, 2023
@robhogan
robhogan
deleted the

export-D43436883

branch
February 20, 2023 18:19
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Feb 23, 2023
@huntie@facebook-github-bot
Increase minimum Node version from 14 to 16
e5950ae
Summary:
Following the same change in React Native for the upcoming 0.72 release ([react/react-native#36217](react/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.
Changelog: **[Breaking]** Increase minimum Node version from 14 to 16
Reviewed By: hoxyq
Differential Revision: D43464209
fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation
b3f60ec
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@arushikesarwani94arushikesarwani94
mentioned this pull request
Mar 3, 2023
 Merged

arushikesarwani94 added a commit
to react/react-native-website
that referenced
this pull request
Mar 3, 2023
@arushikesarwani94
Update getting started Windows documentation (#3604)
166b7ad
React Native is increasing the minimum Node JS requirement from 14 to 16 in react/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
@hoxyqhoxyq
mentioned this pull request
Apr 25, 2023
 Closed

facebook-github-bot pushed a commit
that referenced
this pull request
Apr 26, 2023
@Pranav-yadav@facebook-github-bot
Update Node.js to v16 in all RN packages (#37073)
a58dea1
Summary:
**NOTE**: This is a **BREAKING** change.
TLDR; Enforce minimum Node.js v16 in all RN packages.
This diff **Updates Node.js to v16** across all RN packages.
#### Context:
- For RN development and new project created; bump to node 16 was in #36217
- Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500
#### Changes:
- [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir
## Changelog:
[GENERAL][BREAKING] - Update Node.js to v16 in all RN packages
Pull Request resolved: #37073
Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_
Reviewed By: cipolleschi
Differential Revision: D45306108
Pulled By: jacdebug
fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 in Circel CI config
be830d7
Summary:
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Differential Revision: D46584012
fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
@arushikesarwani94arushikesarwani94
mentioned this pull request
Jun 9, 2023
 Closed

arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
96c1173
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
ca9ad66
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
41a2656
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
46922b6
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
d063cfb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
4bf4ca4
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
49761cb
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
2f20547
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
f2b49fe
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
1cb4315
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
adea113
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94 added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (react#1004)
0f1cfaf
Summary:
Pull Request resolved: react#1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot pushed a commit
to react/metro
that referenced
this pull request
Jun 22, 2023
@arushikesarwani94@facebook-github-bot
Increase minimum Node version from 16 to 18 (#1004)
ebaf27a
Summary:
Pull Request resolved: #1004
Following the same change in React Native (react/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18.
Changelog: [Breaking] Increase minimum Node version from 16 to 18
Reviewed By: NickGerleman
Differential Revision: D46584012
fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@robhogan@facebook-github-bot@cortinico