Skip to content

Bump node version from 16 to 18 - #35443

Closed
leotm wants to merge 5 commits into
react:mainfrom
leotm:patch-4
Closed

Bump node version from 16 to 18#35443
leotm wants to merge 5 commits into
react:mainfrom
leotm:patch-4

Conversation

@leotm

@leotmleotm commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2022
@analysis-bot

analysis-bot commented Nov 23, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,102,569+0
androidhermesarmeabi-v7a6,470,637+0
androidhermesx867,520,037+0
androidhermesx86_647,378,724+0
androidjscarm64-v8a8,967,444+0
androidjscarmeabi-v7a7,698,293+0
androidjscx869,029,584+0
androidjscx86_649,507,429+0

Base commit: e11cfe9
Branch: main

@leotmleotm left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@analysis-bot

analysis-bot commented Nov 23, 2022

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: e11cfe9
Branch: main

@pull-bot

Copy link
Copy Markdown

PR build artifact for d4ecaee is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cortinico

Copy link
Copy Markdown
Contributor

I think we can do that, but you'll have to also update the Node version on CircleCI and make sure that everythign is green:
https://github.com/facebook/react-native/blob/main/.circleci/config.yml#L42-L43

Prev-LTS should be 16, and current should be 18.

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see my previous comment)

@leotmleotm changed the title Bump .node-version to 18Bump node-version from 16 to 18Nov 23, 2022
@leotmleotm changed the title Bump node-version from 16 to 18Bump node version from 16 to 18Nov 23, 2022
@pull-bot

Copy link
Copy Markdown

PR build artifact for e26ef04 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@leotm
leotm requested a review from cortinicoNovember 23, 2022 23:39
@kelset

Copy link
Copy Markdown
Contributor

can you fix the changelog entry? [Javascript] is not a valid argument?

@leotm

leotm commented Nov 25, 2022

Copy link
Copy Markdown
ContributorAuthor

looks valid/appropriate no? so it's passing

https://github.com/facebook/react-native/blob/55b09da62a50ee4ef03b53002266e2cc5e8db1c2/packages/react-native-bots/dangerfile.js#L62

if js/javascript been deprecated, happy to create another PR to remove both opts and update to [General]

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kelset

Copy link
Copy Markdown
Contributor

looks valid/appropriate no? so it's passing

https://github.com/facebook/react-native/blob/55b09da62a50ee4ef03b53002266e2cc5e8db1c2/packages/react-native-bots/dangerfile.js#L62

if js/javascript been deprecated, happy to create another PR to remove both opts and update to [General]

oh wow then the docs are outdated 😅 https://reactnative.dev/contributing/changelogs-in-pull-requests <- that one will need to be fixed; thanks for spotting!

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @leotm in f75b92a.

When will my fix make it into a release? | Upcoming Releases

@react-native-botreact-native-bot added the Merged This PR has been merged. label Nov 25, 2022
facebook-github-bot pushed a commit that referenced this pull request Dec 5, 2022
…PR template (#35541)
Summary:
A few days back leotm pointed out how the dangerfile was disaligned with the docs around the valid changelog entries for categories and types here: #35443 (comment)
I dug a bit deeper into the whole thing and went to the source of truth, which is the changelog generator, in particular here: https://github.com/microsoft/rnx-kit/blob/main/incubator/rn-changelog-generator/src/utils/getChangeDimensions.ts
So I've updated the dangerfile to respect the options listed there. Also did a parallel PR on the website side: react/react-native-website#3447
So now all comms will be aligned.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[INTERNAL] [FIXED] - fix changelog entries for dangerfiles and PR template
Pull Request resolved: #35541
Test Plan: N/A
Reviewed By: sammy-SC
Differential Revision: D41686913
Pulled By: cortinico
fbshipit-source-id: 2297b4a3209188bda4a609b60860de35c5e7e6df
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@leotm@analysis-bot@pull-bot@cortinico@kelset@facebook-github-bot@react-native-bot