Uh oh!
There was an error while loading. Please reload this page.
Export EmitterSubscription TypeScript Type - #36632
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 24, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44375081 |
facebook-github-bot
commented
Mar 24, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44375081 |
NickGerlemanforce-pushed
the
export-D44375081
branch
from
March 24, 2023 17:50
29c2615 to
202ee5dCompare
Base commit: 72d2880 |
facebook-github-bot
commented
Mar 24, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44375081 |
NickGerlemanforce-pushed
the
export-D44375081
branch
from
March 24, 2023 18:50
202ee5d to
72a2308Comparefacebook-github-bot
commented
Apr 17, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44375081 |
NickGerlemanforce-pushed
the
export-D44375081
branch
from
April 17, 2023 17:57
72a2308 to
ae3af89CompareSummary: Pull Request resolved: react#36632 Discovered when bumping the RN documentation to typecheck against 0.72, react#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: 4f5e2b36a42c5917cea37a6f0cd0b53420cf6b27
facebook-github-bot
commented
Apr 17, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D44375081 |
NickGerlemanforce-pushed
the
export-D44375081
branch
from
April 17, 2023 18:02
ae3af89 to
25a44d1Comparefacebook-github-bot
commented
Apr 17, 2023
Contributor
This pull request has been merged in eb83356. |
kelset pushed a commit
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: #36632 Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the
EmitterSubscriptiontype which should be kept public.Changelog:
[General][Fixed] - Export EmitterSubscription TypeScript Type
Differential Revision: D44375081