Skip to content

Port changes from main into Stable to make the CI green - #36665

Merged
cipolleschi merged 2 commits into
0.72-stablefrom
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged

Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom
cipolleschi/fix_disable_ios_integration_tests

Conversation

@cipolleschi

@cipolleschicipolleschi commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Summary

This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI

Changelog

[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests

Test Plan

  • JS Tests on CircleCI should be green now

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_disable_ios_integration_tests branch from c70961d to 8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie mentioned this pull request Mar 28, 2023
Merged
@cipolleschicipolleschi changed the title Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 7929d67 to 3cf42ccCompareMarch 28, 2023 13:01
@github-actions

github-actionsBot commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc

@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 3cf42cc to 0db6355CompareMarch 28, 2023 13:08
@analysis-bot

analysis-bot commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620

Base commit: a83c192
Branch: main

@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_disable_ios_integration_tests branch 3 times, most recently from 63566d0 to 2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix_disable_ios_integration_tests branch from 2104e77 to 4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi merged commit 9ffe82e into 0.72-stableMar 28, 2023
@cipolleschi
cipolleschi deleted the cipolleschi/fix_disable_ios_integration_tests branch March 28, 2023 21:32
This was referenced Aug 10, 2023
Closed
Merged
@cipolleschicipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Oct 12, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Nov 1, 2023
Merged
@stevenpetrykstevenpetryk mentioned this pull request Nov 28, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
This was referenced Jan 10, 2024
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Port changes from main into Stable to make the CI green by cipolleschi · Pull Request #36665 · react/react-native · GitHub
Skip to content
Port changes from main into Stable to make the CI green - #36665
Merged
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green#36665
cipolleschi merged 2 commits into
0.72-stablefrom 
cipolleschi/fix_disable_ios_integration_tests
Conversation
@cipolleschi
@cipolleschicipolleschi
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan
  • JS Tests on CircleCI should be green now
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

labels
Mar 27, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
c70961d to
8a1f167CompareMarch 27, 2023 18:25
@huntiehuntie
mentioned this pull request
Mar 28, 2023
 Merged

@cipolleschicipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from mainPort changes from main into Stable to make the CI greenMar 28, 2023
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
7929d67 to
3cf42ccCompareMarch 28, 2023 13:01
@github-actions
github-actionsBot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4d245cc
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
3cf42cc to
0db6355CompareMarch 28, 2023 13:08
@analysis-bot
analysis-bot
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,539,304+19,609
androidhermesarmeabi-v7a7,854,901+19,093
androidhermesx869,019,156+20,535
androidhermesx86_648,874,224+19,323
androidjscarm64-v8a9,140,608-253
androidjscarmeabi-v7a8,332,247-753
androidjscx869,195,190+643
androidjscx86_649,453,020-620
Base commit: a83c192

Branch: main
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
63566d0 to
2104e77CompareMarch 28, 2023 15:45
@huntieRiccardo Cipolleschi
Add @react-native/metro-config package (#36502)
4d245cc
Summary:
Changelog:
[General][Added] - Add `react-native/metro-config` package
Pull Request resolved: #36502
## Context
### React Native Metro config → React Native repo (#36502)
We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
**See full motivation, design, and test plan here: #36502
## Changes
- This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user.
{F906910591}
Reviewed By: cortinico
Differential Revision: D44099692
fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
@cipolleschi
cipolleschiforce-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
2104e77 to
4d245ccCompareMarch 28, 2023 16:10
@cipolleschi
cipolleschi
merged commit 9ffe82e
into
0.72-stableMar 28, 2023
@cipolleschi
cipolleschi
deleted the

cipolleschi/fix_disable_ios_integration_tests

branch
March 28, 2023 21:32

This was referenced Aug 10, 2023
 Closed

 Merged

@cipolleschicipolleschi
mentioned this pull request
Sep 21, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Oct 12, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Nov 1, 2023
 Merged

@stevenpetrykstevenpetryk
mentioned this pull request
Nov 28, 2023
 Merged

@cipolleschicipolleschi
mentioned this pull request
Dec 27, 2023
 Merged


This was referenced Jan 4, 2024
 Merged

 Merged


This was referenced Jan 10, 2024
 Merged

 Closed


This was referenced Feb 28, 2024
 Merged

 Merged

 Merged

@cipolleschicipolleschi
mentioned this pull request
Jun 28, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@lunaleapslunaleapslunaleaps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@cipolleschi@analysis-bot@lunaleaps@facebook-github-bot@react-native-bot@huntie