') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix the setup to allow the build-from-source on host projects by cortinico · Pull Request #36702 · react/react-native · GitHub
Skip to content

Fix the setup to allow the build-from-source on host projects - #36702

Closed
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D44502428
Closed

Fix the setup to allow the build-from-source on host projects#36702
cortinico wants to merge 1 commit into
react:mainfrom
cortinico:export-D44502428

Conversation

@cortinico

@cortinicocortinico commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Summary:
With the monorepo changes we broke the build from source for users.
This fixes it so that folks can just follow the guide:
https://reactnative.dev/contributing/how-to-build-from-source

Changelog:
[Android] [Fixed] - Fix the setup to allow the build-from-source on host projects

Differential Revision: D44502428

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 29, 2023
@facebook-github-bot

facebook-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44502428

@cortinicocortinico mentioned this pull request Mar 29, 2023
Merged
hoxyq
hoxyq approved these changes Mar 29, 2023
View reviewed changes

@hoxyqhoxyq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I am not an expert on Gradle.

Any plans on moving tasks from <root>/build.gradle.kts to <root>/packages/react-native/build.gradle.kts and adding proxy-ing?

@analysis-bot

analysis-bot commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,546,664+0
androidhermesarmeabi-v7a7,861,177+0
androidhermesx869,027,965+0
androidhermesx86_648,883,653+0
androidjscarm64-v8a9,167,110+0
androidjscarmeabi-v7a8,357,650+0
androidjscx869,223,172+0
androidjscx86_649,481,667+0

Base commit: 8eb28e7
Branch: main

@facebook-github-bot

facebook-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44502428

@cortinico@facebook-github-bot
Fix the setup to allow the build-from-source on host projects (react#…
9af9c50
…36702)
Summary:
Pull Request resolved: react#36702
With the monorepo changes we broke the build from source for users.
This fixes it so that folks can just follow the guide:
https://reactnative.dev/contributing/how-to-build-from-source
Changelog:
[Android] [Fixed] - Fix the setup to allow the build-from-source on host projects
Reviewed By: cipolleschi
Differential Revision: D44502428
fbshipit-source-id: 4e351b45b13370e5c082004bc6567007c57e6ee7
@facebook-github-bot

facebook-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44502428

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 29, 2023
@facebook-github-bot

facebook-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

This pull request has been merged in fec5658.

kelset pushed a commit that referenced this pull request Mar 29, 2023
@cortinico@kelset
Fix the setup to allow the build-from-source on host projects (#36702)
14794a9
Summary:
Pull Request resolved: #36702
With the monorepo changes we broke the build from source for users.
This fixes it so that folks can just follow the guide:
https://reactnative.dev/contributing/how-to-build-from-source
Changelog:
[Android] [Fixed] - Fix the setup to allow the build-from-source on host projects
Reviewed By: cipolleschi
Differential Revision: D44502428
fbshipit-source-id: 3ad8fb114f5e2f7ffdf6fffa617ceaa45334f5f3
@cortinico

cortinico commented Mar 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Any plans on moving tasks from <root>/build.gradle.kts to <root>/packages/react-native/build.gradle.kts and adding proxy-ing?

@hoxyq Nope I don't think we'll be doing this for now, as those will be exposed to users, and I'm trying to keep the <root>/packages/react-native/build.gradle.kts file as streamlined as possible

@kelset

kelset commented May 3, 2023

Copy link
Copy Markdown
Contributor

@cortinico do we need to cherry-pick this in 0.72 branch?

@cortinico

cortinico commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Yup this needs to be backported 👍

This was referenced Aug 10, 2023
Closed
Merged
@cipolleschicipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Oct 12, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Nov 1, 2023
Merged
@stevenpetrykstevenpetryk mentioned this pull request Nov 28, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hoxyqhoxyqhoxyq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BugCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartnerPlatform: AndroidAndroid applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cortinico@facebook-github-bot@analysis-bot@kelset@hoxyq@react-native-bot