Skip to content

fix(ios): fix pod install --project-directory=ios failing - #37994

Merged
tido64 merged 3 commits into
0.72-stablefrom
tido/fix-codegen-0.72
Jun 23, 2023
Merged

fix(ios): fix pod install --project-directory=ios failing#37994
tido64 merged 3 commits into
0.72-stablefrom
tido/fix-codegen-0.72

Conversation

@tido64

@tido64tido64 commented Jun 21, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:

image

pod install --project-directory=ios currently fails when new arch is enabled: react-native-async-storage/async-storage#910

Changelog:

[IOS] [FIXED] - Fix pod install --project-directory=... when New Arch is enabled

Test Plan:

git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
gh pr checkout 910
yarn
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=example/ios

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jun 21, 2023
@tido64tido64 mentioned this pull request Jun 21, 2023
Closed
@analysis-bot

analysis-bot commented Jun 21, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,545,460-412,666
androidhermesarmeabi-v7a7,859,634-359,679
androidhermesx869,024,364-447,427
androidhermesx86_648,878,906-435,354
androidjscarm64-v8a9,145,056-374,007
androidjscarmeabi-v7a8,335,014-322,577
androidjscx869,198,313-405,292
androidjscx86_649,455,901-394,279

Base commit: b3bb553
Branch: main

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2023
@tido64@facebook-github-bot
fix(ios): fixpod install --project-directory=iosfailing (#37992)
eb5f23c
Summary:
![image](https://user-images.githubusercontent.com/4123478/217618490-4f99e408-1a07-4acf-a05c-e8837562a931.png)
`pod install --project-directory=ios` currently fails when new arch is enabled: react-native-async-storage/async-storage#910
- Patch for 0.71: #37993
- Patch for 0.72: #37994
## Changelog:
[IOS] [FIXED] - Fix `pod install --project-directory=...` when New Arch is enabled
Pull Request resolved: #37992
Test Plan:
```
git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
gh pr checkout 910
yarn
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=example/ios
```
Reviewed By: cortinico
Differential Revision: D46966225
Pulled By: cipolleschi
fbshipit-source-id: 00b4650189175c09c9ec928f85d075890ba4c7c1
@tido64
tido64 merged commit 0b96bdc into 0.72-stableJun 23, 2023
@tido64
tido64 deleted the tido/fix-codegen-0.72 branch June 23, 2023 11:44
@NOUIYNOUIY mentioned this pull request Jul 21, 2023
Open
This was referenced Aug 10, 2023
Closed
Merged
@cipolleschicipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Oct 12, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Nov 1, 2023
Merged
@stevenpetrykstevenpetryk mentioned this pull request Nov 28, 2023
Merged
@cipolleschicipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschicipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschicipolleschicipolleschi approved these changes
@cortinicocortinicoAwaiting requested review from cortinico
@kelsetkelsetAwaiting requested review from kelset

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: MicrosoftPartner: MicrosoftPartnerPick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tido64@analysis-bot@cipolleschi@facebook-github-bot