Skip to content

For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase - #38256

Closed
apuruni wants to merge 1 commit into
react:mainfrom
apuruni:export-D47313501
Closed

For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase#38256
apuruni wants to merge 1 commit into
react:mainfrom
apuruni:export-D47313501

Conversation

@apuruni

Copy link
Copy Markdown
Contributor

Summary:
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

Differential Revision: D47313501

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 8, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

@analysis-bot

analysis-bot commented Jul 8, 2023

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a9,001,916+0
androidhermesarmeabi-v7a8,255,977-2
androidhermesx869,511,054-1
androidhermesx86_649,356,939+0
androidjscarm64-v8a9,614,950+0
androidjscarmeabi-v7a8,741,582-1
androidjscx869,701,900-4
androidjscx86_649,948,458+0

Base commit: c82f2e9
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

…flag support in DevSupportManagerBase (react#38256)
Summary:
Pull Request resolved: react#38256
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```
Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase
Reviewed By: javache
Differential Revision: D47313501
fbshipit-source-id: 0fade223c8629a2050dc440fd975da0bc9ee94aa
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D47313501

@github-actions

Copy link
Copy Markdown

This pull request was successfully merged by @apuruni in 177d97d.

When will my fix make it into a release? | Upcoming Releases

@github-actionsgithub-actionsBot added the Merged This PR has been merged. label Jul 10, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 177d97d.

lunaleaps pushed a commit that referenced this pull request Aug 7, 2023
…flag support in DevSupportManagerBase (#38256)
Summary:
Pull Request resolved: #38256
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```
Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase
Reviewed By: javache
Differential Revision: D47313501
fbshipit-source-id: 12e8299559d08b4ff87b4bdabb0a29d27763c698
AndyG added a commit to discord/react-native-archived that referenced this pull request Nov 3, 2023
yogevbd pushed a commit to wix/react-native-navigation that referenced this pull request Nov 6, 2023
From react native [pr](react/react-native#38256)
> Summary:
> Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
> https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
> > Without this fix, app crashes during launch because of :
> SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts
@thuongtv-vn

Copy link
Copy Markdown

Hi All,

Can we create patch file for those changes?

@Girum

Girum commented Jan 4, 2024

Copy link
Copy Markdown

Hi! Ai updated from react native from 0.70.6 to 0.72.8, and the error persists. How to resolve?

Flewp pushed a commit to discord/react-native-archived that referenced this pull request Mar 9, 2024
1t5j0y added a commit to avniproject/avni-client that referenced this pull request Jul 18, 2024
- building using gradle 8 throws errors if any dependencies have package name specified in AndroidManifest.xml
-- Addressed by patching AndroidManifest.xml of each affected dependency to remove package and added namespace to corresponding build.gradle
-- For amazon-cognito-identity-js, addressed by upgrading dependency to a later patch version with this change
- react-native-vector-icons needed additional patching for other breaking issues in gradle 8 - oblador/react-native-vector-icons#1588
- react-native-video upgraded from 5.2.0 to 5.2.1 to fixTheWidlarzGroup/react-native-video#3160.
-- Changes in existing patch for 5.2.0 are already included in react-native-video release 5.2.1
- react-native upgraded from 0.72.3 to 0.72.8 to get fix for react/react-native#38256 which was causing crash on launch
-- Additionally, did an override of registerReceiver in MainApplication.java react/react-native#41288
@chirag-blueed

Copy link
Copy Markdown

Which version of React Native includes these features? We are using 0.68.2, and I am still facing the issue. Can someone guide here?

chrisbobbe pushed a commit to zulip/react-native that referenced this pull request Sep 21, 2024
…flag support in DevSupportManagerBase (react#38256)
Summary:
Pull Request resolved: react#38256
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
Without this fix, app crashes during launch because of :
```SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts```
Changelog:
[Targeting SDK 34] Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase
Reviewed By: javache
Differential Revision: D47313501
fbshipit-source-id: 12e8299559d08b4ff87b4bdabb0a29d27763c698
(Cherry picked from commit 177d97d to support targetSdkVersion = 34.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@apuruni@facebook-github-bot@analysis-bot@thuongtv-vn@Girum@chirag-blueed