Uh oh!
There was an error while loading. Please reload this page.
Fabric Interop - Properly dispatch integer commands - #38527
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jul 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47600094 |
facebook-github-bot
commented
Jul 20, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47600094 |
Base commit: f6197cd |
facebook-github-bot
commented
Jul 21, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47600094 |
Summary: Pull Request resolved: react#38527 This fixes a bug that got reported for the Fabric Interop for Android with Command dispatching. (See terrylinla/react-native-sketch-canvas#236) The problem is that libraries that were receiving commands as ints with: ``` public void receiveCommand( int surfaceId, int reactTag, int commandId, Nullable ReadableArray commandArgs) { ``` would not receive command with the Fabric Interop for Android. The problem is that with Fabric, events are dispatched as string always. cipolleschi took care of this for iOS, but we realized that the Android part was missing. I'm adding it here. The logic is, if the event is dispatched as a string that represents a number (say `"42"`) and the user has Fabric Interop enabled, then we dispatch the event as `int` (so libraries will keep on working). Changelog: [Android] [Fixed] - Fabric Interop - Properly dispatch integer commands Reviewed By: cipolleschi Differential Revision: D47600094 fbshipit-source-id: adb789abc529b9b1aa0dfcf979ac16856a31135d
facebook-github-bot
commented
Jul 21, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D47600094 |
This pull request was successfully merged by @cortinico in ccc50dd. When will my fix make it into a release? | Upcoming Releases |
cortinico added a commit
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: #38527 This fixes a bug that got reported for the Fabric Interop for Android with Command dispatching. (See terrylinla/react-native-sketch-canvas#236) The problem is that libraries that were receiving commands as ints with: ``` public void receiveCommand( int surfaceId, int reactTag, int commandId, Nullable ReadableArray commandArgs) { ``` would not receive command with the Fabric Interop for Android. The problem is that with Fabric, events are dispatched as string always. cipolleschi took care of this for iOS, but we realized that the Android part was missing. I'm adding it here. The logic is, if the event is dispatched as a string that represents a number (say `"42"`) and the user has Fabric Interop enabled, then we dispatch the event as `int` (so libraries will keep on working). Changelog: [Android] [Fixed] - Fabric Interop - Properly dispatch integer commands Reviewed By: cipolleschi Differential Revision: D47600094 fbshipit-source-id: c35f0509e6c6c0cddc7090a069882f92dd95532e
lunaleaps pushed a commit
that referenced
this pull request
Aug 8, 2023
lunaleaps pushed a commit
that referenced
this pull request
Aug 10, 2023
Kudo pushed a commit
to expo/react-native
that referenced
this pull request
Aug 21, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a bug that got reported for the Fabric Interop for Android with Command dispatching.
(See terrylinla/react-native-sketch-canvas#236)
The problem is that libraries that were receiving commands as ints with:
would not receive command with the Fabric Interop for Android.
The problem is that with Fabric, events are dispatched as string always.
cipolleschi took care of this for iOS, but we realized that the Android part was missing. I'm adding it here.
The logic is, if the event is dispatched as a string that represents a number (say
"42") and the user has Fabric Interop enabled, then we dispatch the event asint(so libraries will keep on working).Changelog:
[Android] [Fixed] - Fabric Interop - Properly dispatch integer commands
Differential Revision: D47600094