Uh oh!
There was an error while loading. Please reload this page.
forward-compatible use of u8"..." strings - #39264
Closed
yfeldblum wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48908076 |
Base commit: 7a0d2a0 |
yfeldblum added a commit
to yfeldblum/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39264 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D48908076
yfeldblumforce-pushed
the
export-D48908076
branch
from
September 1, 2023 18:47
6fb7da5 to
52ecae9Comparefacebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48908076 |
yfeldblumforce-pushed
the
export-D48908076
branch
from
September 1, 2023 19:32
52ecae9 to
ccf6705Comparefacebook-github-bot
commented
Sep 1, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48908076 |
yfeldblum added a commit
to yfeldblum/hermes
that referenced
this pull request
Sep 2, 2023
Summary: X-link: react/react-native#39264 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D48908076
Summary: X-link: facebook/hermes#1113 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D48908076
yfeldblum added a commit
to yfeldblum/hermes
that referenced
this pull request
Sep 2, 2023
Summary: X-link: react/react-native#39264 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D48908076
facebook-github-bot
commented
Sep 2, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D48908076 |
yfeldblumforce-pushed
the
export-D48908076
branch
from
September 2, 2023 22:48
ccf6705 to
713469aComparefacebook-github-bot pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 2, 2023
Summary: X-link: react/react-native#39264 Pull Request resolved: #1113 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D48908076 fbshipit-source-id: e68d8fc4ff9dfb9528846901e37e2775c2b98866
facebook-github-bot
commented
Sep 2, 2023
Contributor
This pull request has been merged in 041f459. |
facebook-github-bot pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 8, 2023
Summary: Original Author: yfeldblum@meta.com Original Git: f5bf171 Original Reviewed By: christophpurrer Original Revision: D48908076 X-link: react/react-native#39264 Pull Request resolved: #1113 Since C++20, the type of a `u8"..."` string literal is `const char8_t[N]` whereas prior to C++20 the type is `const char[N]`. `char8_t` has the same size, alignment, and signedness as `unsigned char` but is a different type from `unsigned char`, as well as being a different type from `signed char` and from `char`. In context, the uses of the `u8"..."` expect `const char*` (to which `const char[N]` decays) and not `const char8_t*` (to which `const char8_t[N]` decays). To fit the string to the context since C++20, we must `reinterpret_cast` to `const char*`; this is a type-level no-op prior to C++20. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D50992883 fbshipit-source-id: e2f126485d80f6f2e1f5c6bcfabbabd53fe01b85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hermes#1113
Since C++20, the type of a
u8"..."string literal isconst char8_t[N]whereas prior to C++20 the type isconst char[N].char8_thas the same size, alignment, and signedness asunsigned charbut is a different type fromunsigned char, as well as being a different type fromsigned charand fromchar.In context, the uses of the
u8"..."expectconst char*(to whichconst char[N]decays) and notconst char8_t*(to whichconst char8_t[N]decays). To fit the string to the context since C++20, we mustreinterpret_casttoconst char*; this is a type-level no-op prior to C++20.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D48908076