Skip to content

forward-compatible use of u8"..." strings#39264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yfeldblum wants to merge 1 commit into from
Closed

forward-compatible use of u8"..." strings #39264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native/ReactCommon/jsi/jsi/test/testlib.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,8 @@ TEST_P(JSITest, PropNameIDTest) {
rt, movedQuux, PropNameID::forAscii(rt, std::string("foo"))));
uint8_t utf8[] = {0xF0, 0x9F, 0x86, 0x97};
PropNameID utf8PropNameID = PropNameID::forUtf8(rt, utf8, sizeof(utf8));
EXPECT_EQ(utf8PropNameID.utf8(rt), u8"\U0001F197");
EXPECT_EQ(
utf8PropNameID.utf8(rt), reinterpret_cast<const char*>(u8"\U0001F197"));
EXPECT_TRUE(PropNameID::compare(
rt, utf8PropNameID, PropNameID::forUtf8(rt, utf8, sizeof(utf8))));
PropNameID nonUtf8PropNameID = PropNameID::forUtf8(rt, "meow");
Expand DownExpand Up@@ -532,7 +533,7 @@ TEST_P(JSITest, FunctionTest) {
"s1",
String::createFromAscii(rt, "s2"),
std::string{"s3"},
std::string{u8"s\u2600"},
std::string{reinterpret_cast<const char*>(u8"s\u2600")},
// invalid UTF8 sequence due to unexpected continuation byte
std::string{"s\x80"},
Object(rt),
Expand Down