Uh oh!
There was an error while loading. Please reload this page.
Add assets-registry to shared build setup - #39542
Closed
huntie wants to merge 1 commit into
Closed
Conversation
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
September 19, 2023 16:34
a202b67 to
9510cc5Compare
|
huntieforce-pushed
the
huntie/build-assets-registry
branch
3 times, most recently
from
February 15, 2024 15:43
aed6d06 to
49d202bComparehuntieforce-pushed
the
huntie/build-assets-registry
branch
2 times, most recently
from
February 28, 2024 19:11
4ebeb7e to
e570fcfComparehuntieforce-pushed
the
huntie/build-assets-registry
branch
from
April 5, 2024 14:38
e570fcf to
4f5e87aCompareanalysis-bot
commented
Apr 5, 2024
Base commit: bc832ca |
huntieforce-pushed
the
huntie/build-assets-registry
branch
2 times, most recently
from
April 11, 2024 13:59
f79d0f0 to
7d3ab2cComparetido64
commented
Jul 31, 2024
Collaborator
@huntie: Any chance we can revive this? The original PR got closed. |
huntie
commented
Jul 31, 2024
CollaboratorAuthor
@tido64 Yup! I might be able to put this on my Friday plate. This was really close to working but didn't quite line up. |
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
September 27, 2024 16:20
7d3ab2c to
cc3725cCompareCollaborator
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
September 27, 2024 16:22
cc3725c to
0d3f6e5CompareJob Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: build_android
|
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
September 27, 2024 16:27
0d3f6e5 to
bd16cbfCompareJob Summary for GradleTest All :: build_android
|
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
September 27, 2024 16:35
bd16cbf to
8d86799CompareJob Summary for GradleTest All :: build_android
|
This was referenced Jan 2, 2025
facebook-github-bot pushed a commit
that referenced
this pull request
Jan 2, 2025
Summary: Pull Request resolved: #48458 NOTE: This change is made once and is not guaranteed. **Motivation**: Requiring Flow parsing for `react-native` and its dependencies in user space can involve friction. For the case of `react-native/assets-registry` → `react-native-web`, I believe we should do the pragmatic thing to relax this requirement. - This is a convenience stopgap until #39542 can be stabilised. - This package is tiny and infrequently modified — I believe it's pragmatic/safe to do a one-time conversion, with the above notice and no changelog (i.e. "experimental" for now). Resolves#48349. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67764460 fbshipit-source-id: 7687fd79c6dea73c234a46e475c1cc745225830b
robhogan pushed a commit
that referenced
this pull request
Jan 15, 2025
Summary: Pull Request resolved: #48458 NOTE: This change is made once and is not guaranteed. **Motivation**: Requiring Flow parsing for `react-native` and its dependencies in user space can involve friction. For the case of `react-native/assets-registry` → `react-native-web`, I believe we should do the pragmatic thing to relax this requirement. - This is a convenience stopgap until #39542 can be stabilised. - This package is tiny and infrequently modified — I believe it's pragmatic/safe to do a one-time conversion, with the above notice and no changelog (i.e. "experimental" for now). Resolves#48349. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D67764460 fbshipit-source-id: 7687fd79c6dea73c234a46e475c1cc745225830b
huntieforce-pushed
the
huntie/build-assets-registry
branch
4 times, most recently
from
March 11, 2025 16:48
823b3df to
22f98fcCompareJob Summary for GradleTest All :: build_android
|
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
March 11, 2025 16:56
22f98fc to
5b1a82bCompareJob Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: build_android
|
huntieforce-pushed
the
huntie/build-assets-registry
branch
from
March 11, 2025 17:21
5b1a82b to
13e8217CompareJob Summary for GradleTest All :: build_android
|
huntie
commented
Mar 28, 2025
CollaboratorAuthor
Abandon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR where I'm testing #39440.
Changelog: [Internal]