Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Add assets-registry to shared build setup #39542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .flowconfig
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down
5 changes: 5 additions & 0 deletions packages/assets/.gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist
12 changes: 12 additions & 0 deletions packages/assets/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
"support"
],
"bugs": "https://github.com/facebook/react-native/issues",
"exports": {
"./path-support": "./src/path-support.js",
"./path-support.js": "./src/path-support.js",
"./registry": "./src/registry.js",
"./registry.js": "./src/registry.js",
"./package.json": "./package.json"
},
"files": [
"dist",
"path-support.js",
"registry.js"
],
"engines": {
"node": ">=18"
}
Expand Down
0 ...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js
View file
Open in desktop
File renamed without changes.
27 changes: 9 additions & 18 deletions packages/assets/path-support.js → packages/assets/src/path-support.flow.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
*
* @flow strict
* @format
* @oncall react_native
*/

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
'0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
* FIXME: using number to represent discrete scale numbers is fragile in essence because of
* floating point numbers imprecision.
*/
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
if (scale.toString() in androidScaleSuffix) {
// $FlowFixMe[invalid-computed-prop]
return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
'xml',
]);

function getAndroidResourceFolderName(
asset /*: PackagerAsset */,
scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
asset: PackagerAsset,
scale: number,
): string {
if (!drawableFileTypes.has(asset.type)) {
return 'raw';
}
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
return (getBasePath(asset) + '/' + asset.name)
.toLowerCase()
.replace(/\//g, '_') // Encode folder structure in file name
.replace(/([^a-z0-9_])/g, '') // Remove illegal chars
.replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
const basePath = asset.httpServerLocation;
return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
getAndroidResourceFolderName,
getAndroidResourceIdentifier,
getBasePath,
};
21 changes: 21 additions & 0 deletions packages/assets/src/path-support.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict
* @format
* @oncall react_native
*/

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
// $FlowIgnore[nonstrict-import]
require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';
13 changes: 4 additions & 9 deletions packages/assets/registry.js → packages/assets/src/registry.flow.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
*
* @flow strict
* @format
* @oncall react_native
*/

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
+resolver?: AssetDestPathResolver,
...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
// `push` returns new array length, so the first asset will
// get id 1 (not 0) to make the value truthy
return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};
21 changes: 21 additions & 0 deletions packages/assets/src/registry.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow strict
* @format
* @oncall react_native
*/

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
// $FlowIgnore[nonstrict-import]
require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';
1 change: 1 addition & 0 deletions packages/helloworld/metro.config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
// Make Metro able to resolve required external dependencies
watchFolders: [
path.resolve(__dirname, '../../node_modules'),
path.resolve(__dirname, '../../scripts'), // babel-register.js
path.resolve(__dirname, '../assets'),
path.resolve(__dirname, '../normalize-color'),
path.resolve(__dirname, '../polyfills'),
Expand Down
9 changes: 5 additions & 4 deletions packages/react-native/Libraries/Image/AssetRegistry.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
registerAsset: (asset: PackagerAsset) => number,
getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
require('@react-native/assets-registry/registry') as $FlowFixMe as {
registerAsset: (asset: PackagerAsset) => number,
getAssetByID: (assetId: number) => PackagerAsset,
};

module.exports = AssetRegistry;
1 change: 1 addition & 0 deletions packages/react-native/metro.config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
// Make Metro able to resolve required packages that might be imported from /packages/react-native
watchFolders: [
path.resolve(__dirname, '../../node_modules'),
path.resolve(__dirname, '../../scripts'), // babel-register.js
path.resolve(__dirname, '../assets'),
path.resolve(__dirname, '../normalize-color'),
path.resolve(__dirname, '../polyfills'),
Expand Down
14 changes: 9 additions & 5 deletions packages/rn-tester/.babelrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
"presets": [
"module:@react-native/babel-preset"
],
"plugins": [
"babel-plugin-transform-flow-enums"
"presets": ["module:@react-native/babel-preset"],
"plugins": [
"babel-plugin-transform-flow-enums",
[
"babel-plugin-transform-define",
{
"process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
}
]
]
}
1 change: 1 addition & 0 deletions packages/rn-tester/metro.config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
// Make Metro able to resolve required external dependencies
watchFolders: [
path.resolve(__dirname, '../../node_modules'),
path.resolve(__dirname, '../../scripts'), // babel-register.js
path.resolve(__dirname, '../assets'),
path.resolve(__dirname, '../community-cli-plugin'),
path.resolve(__dirname, '../dev-middleware'),
Expand Down
12 changes: 11 additions & 1 deletion scripts/build/config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
// The target runtime to compile for.
target: 'node',
target:
| 'node'
// Special case for @react-native/assets-registry, where this is consumed
// both by Node.js build tooling and React Native at runtime.
| 'node-like',

// Whether to emit Flow definition files (.js.flow) (default: true).
emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
/* eslint sort-keys: "error" */
packages: {
assets: {
emitTypeScriptDefs: true,
target: 'node-like',
},
'community-cli-plugin': {
target: 'node',
},
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

switch (target) {
case 'node':
case 'node-like':
return require('./babel/node.config.js');
}
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

switch (target) {
case 'node':
case 'node-like':
return {
...require('@tsconfig/node18/tsconfig.json').compilerOptions,
moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add assets-registry to shared build setup#39542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

huntie
wants to merge
1
commit into

from

 Closed


Add assets-registry to shared build setup
#39542
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.flowconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,6 @@ munge_underscores=true

module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/packages/react-native/index.js'
module.name_mapper='^react-native/\(.*\)$' -> '<PROJECT_ROOT>/packages/react-native/\1'
module.name_mapper='^@react-native/dev-middleware$' -> '<PROJECT_ROOT>/packages/dev-middleware'
module.name_mapper='^@?[./a-zA-Z0-9$_-]+\.\(bmp\|gif\|jpg\|jpeg\|png\|psd\|svg\|webp\|m4v\|mov\|mp4\|mpeg\|mpg\|webm\|aac\|aiff\|caf\|m4a\|mp3\|wav\|html\|pdf\|xml\)$' -> '<PROJECT_ROOT>/packages/react-native/Libraries/Image/RelativeImageStub'

suppress_type=$FlowIssue
Expand Down

5 changes: 5 additions & 0 deletions
packages/assets/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
# Dependencies
/node_modules

# Build output
/dist

12 changes: 12 additions & 0 deletions
packages/assets/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,18 @@
 "support"
 ],
 "bugs": "https://github.com/facebook/react-native/issues",
 "exports": {
 "./path-support": "./src/path-support.js",
 "./path-support.js": "./src/path-support.js",
 "./registry": "./src/registry.js",
 "./registry.js": "./src/registry.js",
 "./package.json": "./package.json"
 },
 "files": [
 "dist",
 "path-support.js",
 "registry.js"
 ],
 "engines": {
 "node": ">=18"
 }
Expand Down

0
...ges/assets/__tests__/path-support-test.js → ...assets/src/__tests__/path-support-test.js

View file


Open in desktop


File renamed without changes.


27 changes: 9 additions & 18 deletions
packages/assets/path-support.js → packages/assets/src/path-support.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,10 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*:: import type {PackagerAsset} from './registry.js'; */
import type {PackagerAsset} from './registry.flow';

const androidScaleSuffix = {
 '0.75': 'ldpi',
Expand All@@ -27,7 +26,7 @@ const ANDROID_BASE_DENSITY = 160;
 * FIXME: using number to represent discrete scale numbers is fragile in essence because of
 * floating point numbers imprecision.
 */
function getAndroidAssetSuffix(scale /*: number */) /*: string */ {
function getAndroidAssetSuffix(scale: number): string {
 if (scale.toString() in androidScaleSuffix) {
 // $FlowFixMe[invalid-computed-prop]
 return androidScaleSuffix[scale.toString()];
Expand All@@ -51,10 +50,10 @@ const drawableFileTypes = new Set([
 'xml',
]);

function getAndroidResourceFolderName(
 asset /*: PackagerAsset */,
 scale /*: number */,
) /*: string */ {
export function getAndroidResourceFolderName(
 asset: PackagerAsset,
 scale: number,
): string {
 if (!drawableFileTypes.has(asset.type)) {
 return 'raw';
 }
Expand All@@ -72,23 +71,15 @@ function getAndroidResourceFolderName(
 return 'drawable-' + suffix;
}

function getAndroidResourceIdentifier(
 asset /*: PackagerAsset */,
) /*: string */ {
export function getAndroidResourceIdentifier(asset: PackagerAsset): string {
 return (getBasePath(asset) + '/' + asset.name)
 .toLowerCase()
 .replace(/\//g, '_') // Encode folder structure in file name
 .replace(/([^a-z0-9_])/g, '') // Remove illegal chars
 .replace(/^(?:assets|assetsunstable_path)_/, ''); // Remove "assets_" or "assetsunstable_path_" prefix
}

function getBasePath(asset /*: PackagerAsset */) /*: string */ {
export function getBasePath(asset: PackagerAsset): string {
 const basePath = asset.httpServerLocation;
 return basePath.startsWith('/') ? basePath.slice(1) : basePath;
}

module.exports = {
 getAndroidResourceFolderName,
 getAndroidResourceIdentifier,
 getBasePath,
};

21 changes: 21 additions & 0 deletions
packages/assets/src/path-support.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './path-support.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './path-support.flow';

13 changes: 4 additions & 9 deletions
packages/assets/registry.js → packages/assets/src/registry.flow.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,9 @@
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

'use strict';

/*::
export type AssetDestPathResolver = 'android' | 'generic';

export type PackagerAsset = {
Expand All@@ -26,18 +24,15 @@ export type PackagerAsset = {
 +resolver?: AssetDestPathResolver,
 ...
};
*/

const assets /*: Array<PackagerAsset> */ = [];
const assets: Array<PackagerAsset> = [];

function registerAsset(asset /*: PackagerAsset */) /*: number */ {
export function registerAsset(asset: PackagerAsset): number {
 // `push` returns new array length, so the first asset will
 // get id 1 (not 0) to make the value truthy
 return assets.push(asset);
}

function getAssetByID(assetId /*: number */) /*: PackagerAsset */ {
export function getAssetByID(assetId: number): PackagerAsset {
 return assets[assetId - 1];
}

module.exports = {registerAsset, getAssetByID};

21 changes: 21 additions & 0 deletions
packages/assets/src/registry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *
 * @flow strict
 * @format
 * @oncall react_native
 */

/*::
export type * from './registry.flow';
*/

if (process.env.BUILD_EXCLUDE_BABEL_REGISTER == null) {
 // $FlowIgnore[nonstrict-import]
 require('../../../scripts/babel-register').registerForMonorepo();
}

export * from './registry.flow';

1 change: 1 addition & 0 deletions
packages/helloworld/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

9 changes: 5 additions & 4 deletions
packages/react-native/Libraries/Image/AssetRegistry.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,9 +12,10 @@

import type {PackagerAsset} from '@react-native/assets-registry/registry';

const AssetRegistry = require('@react-native/assets-registry/registry') as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
};
const AssetRegistry =
 require('@react-native/assets-registry/registry') as $FlowFixMe as {
 registerAsset: (asset: PackagerAsset) => number,
 getAssetByID: (assetId: number) => PackagerAsset,
 };

module.exports = AssetRegistry;

1 change: 1 addition & 0 deletions
packages/react-native/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ const config = {
 // Make Metro able to resolve required packages that might be imported from /packages/react-native
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../normalize-color'),
 path.resolve(__dirname, '../polyfills'),
Expand Down

14 changes: 9 additions & 5 deletions
packages/rn-tester/.babelrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
{
 "presets": [
 "module:@react-native/babel-preset"
 ],
 "plugins": [
 "babel-plugin-transform-flow-enums"
 "presets": ["module:@react-native/babel-preset"],
 "plugins": [
 "babel-plugin-transform-flow-enums",
 [
 "babel-plugin-transform-define",
 {
 "process.env.BUILD_EXCLUDE_BABEL_REGISTER": true
 }
 ]
 ]
}

1 change: 1 addition & 0 deletions
packages/rn-tester/metro.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,7 @@ const config = {
 // Make Metro able to resolve required external dependencies
 watchFolders: [
 path.resolve(__dirname, '../../node_modules'),
 path.resolve(__dirname, '../../scripts'), // babel-register.js
 path.resolve(__dirname, '../assets'),
 path.resolve(__dirname, '../community-cli-plugin'),
 path.resolve(__dirname, '../dev-middleware'),
Expand Down

12 changes: 11 additions & 1 deletion
scripts/build/config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,11 @@ const {ModuleResolutionKind} = require('typescript');

export type BuildOptions = $ReadOnly<{
 // The target runtime to compile for.
 target: 'node',
 target:
 | 'node'
 // Special case for @react-native/assets-registry, where this is consumed
 // both by Node.js build tooling and React Native at runtime.
 | 'node-like',

 // Whether to emit Flow definition files (.js.flow) (default: true).
 emitFlowDefs?: boolean,
Expand All@@ -39,6 +43,10 @@ export type BuildConfig = $ReadOnly<{
const buildConfig: BuildConfig = {
 /* eslint sort-keys: "error" */
 packages: {
 assets: {
 emitTypeScriptDefs: true,
 target: 'node-like',
 },
 'community-cli-plugin': {
 target: 'node',
 },
Expand DownExpand Up@@ -82,6 +90,7 @@ function getBabelConfig(

 switch (target) {
 case 'node':
 case 'node-like':
 return require('./babel/node.config.js');
 }
}
Expand All@@ -93,6 +102,7 @@ function getTypeScriptCompilerOptions(

 switch (target) {
 case 'node':
 case 'node-like':
 return {
 ...require('@tsconfig/node18/tsconfig.json').compilerOptions,
 moduleResolution: ModuleResolutionKind.NodeJs,
Expand Down