Uh oh!
There was an error while loading. Please reload this page.
Update boost to 1.83.0 - #39552
Closed
Kudo wants to merge 1 commit into
Closed
Conversation
analysis-bot
commented
Sep 20, 2023
Base commit: 7888338 |
Kudo
marked this pull request as ready for review
September 20, 2023 10:12
Kudo
commented
Sep 20, 2023
ContributorAuthor
close in favor of #39555 |
facebook-github-bot pushed a commit
that referenced
this pull request
Sep 20, 2023
Summary: Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost. If we update boost, we don't need the workaround anymore. This PR is based on #39552. Not sure how Meta internally deal with stacked PRs. This PR just adds a new commit based on #39552 anyway. ## Changelog: [IOS][CHANGED] - Remove Xcode 15 `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround for boost Pull Request resolved: #39555 Test Plan: RNTester + Xcode 15 Reviewed By: cortinico Differential Revision: D49454494 Pulled By: cipolleschi fbshipit-source-id: aacabaa130b61598cf8bd206fdbb96d3b50ba74f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Since folly is updated from 17154a6, it is good to bump boost too.
After updating boost, we can remove the Xcode 15
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTIONworkaround, will create another pr to remove that.Changelog:
[GENERAL][CHANGED] - Update boost to 1.83.0
Test Plan: