Uh oh!
There was an error while loading. Please reload this page.
Update boost to 1.83.0 - #39555
Conversation
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks @Kudo for taking care of this! 🙌
cipolleschi
commented
Sep 20, 2023
facebook-github-bot
commented
Sep 20, 2023
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Kudo
commented
Sep 20, 2023
analysis-bot
commented
Sep 20, 2023
Base commit: 7888338 |
facebook-github-bot
commented
Sep 20, 2023
@cipolleschi merged this pull request in b9f0bdd. |
liamjones
commented
May 14, 2024
Something I've just noticed in relation to this PR when upgrading from 0.72.x to 0.73.x - if the Is that an issue or not? I noticed it's a |
cipolleschi
commented
May 20, 2024
@liamjones it should not be an issue. The directive is needed to backport the name of an API that has changed. I don't think that it's an issue if we keep it. Unless you are seeing some specific errors: if that's the case, could you share them? |
@cipolleschi Nope, not seeing any errors. I just noticed it wasn't being removed when I did the RN upgrade and wanted to check if it was deliberate. Thanks for confirming it was! 😄 |
Summary:
Since folly is updated from 17154a6, it is good to bump boost too.
After updating boost, we can remove the Xcode 15
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTIONworkaround which originally to fix Xcode 15 for boost.Changelog:
[GENERAL][CHANGED] - Update boost to 1.83.0
Test Plan: