Uh oh!
There was an error while loading. Please reload this page.
Fix overriding EXCLUDED_ARCHS when installing Hermes on RN v0.71 - #39763
Merged
Conversation
cipolleschi
approved these changes
Oct 4, 2023
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. You can squash and merge!
ken0nekforce-pushed
the
ken0nek/fix-exclude-archs
branch
from
October 4, 2023 19:10
d668ad8 to
c2ff291Compareken0nek
commented
Oct 4, 2023
ContributorAuthor
Resolved the conflict against |
cipolleschi
commented
Oct 6, 2023
Contributor
/rebase |
github-actionsBotforce-pushed
the
ken0nek/fix-exclude-archs
branch
from
October 6, 2023 13:23
c2ff291 to
0a4c1baCompare
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
EXCLUDED_ARCHSwhen installing Hermes on RN v0.71mainRecommended to create a pull request against
0.71.stablehereref: #39060
Changelog:
[IOS] [FIXED] - don't override EXCLUDED_ARCHS when installing Hermes
Test Plan:
Tests pass