Skip to content

Fix overriding EXCLUDED_ARCHS when installing Hermes on RN v0.72 - #43002

Merged
lunaleaps merged 1 commit into
react:0.72-stablefrom
ken0nek:ken0nek/fix-exclude-archs-v0.72
Feb 16, 2024
Merged

Fix overriding EXCLUDED_ARCHS when installing Hermes on RN v0.72#43002
lunaleaps merged 1 commit into
react:0.72-stablefrom
ken0nek:ken0nek/fix-exclude-archs-v0.72

Conversation

@ken0nek

@ken0nekken0nek commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Summary:

Created the same fix on RN v0.72 as the previous fix was only available on RN v0.71 #39763

No need to fix for RN v0.73.

ref

Changelog:

[IOS] [FIXED] - don't override EXCLUDED_ARCHS when installing Hermes

Test Plan:

Tests pass

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2024
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,492,736-8,758,306
androidhermesarmeabi-v7a7810635n/a
androidhermesx868962829n/a
androidhermesx86_648824079n/a
androidjscarm64-v8a9,151,543-11,461,898
androidjscarmeabi-v7a8341174n/a
androidjscx869204833n/a
androidjscx86_649463499n/a

Base commit: 94bfde4
Branch: main

@lunaleaps
lunaleaps merged commit a4282a9 into react:0.72-stableFeb 16, 2024
@ken0nek
ken0nek deleted the ken0nek/fix-exclude-archs-v0.72 branch February 19, 2024 07:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ken0nek@analysis-bot@lunaleaps@facebook-github-bot