Skip to content

Prevent LogBox from crashing on long messages (#38005) - #41989

Merged
fortmarek merged 3 commits into
0.72-stablefrom
fortmarek/prevent-log-box
Dec 19, 2023
Merged

Prevent LogBox from crashing on long messages (#38005)#41989
fortmarek merged 3 commits into
0.72-stablefrom
fortmarek/prevent-log-box

Conversation

@fortmarek

@fortmarekfortmarek commented Dec 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary:

Cherry pick of: #38005

Going through a PR due to merge conflicts.

Changelog:

[GENERAL][FIXED] Prevent LogBox from crashing on very long messages

Test Plan:

@motiz88@fortmarek
Prevent LogBox from crashing on long messages (#38005)
b0291de
Summary:
Pull Request resolved: #38005Fixes#32093 by guarding the expensive `BABEL_CODE_FRAME_ERROR_FORMAT` regex with a cheaper initial scan. (Longer term, we should reduce our reliance on string parsing and propagate more structured errors.)
Changelog: [General][Fixed] Prevent LogBox from crashing on very long messages
Reviewed By: GijsWeterings
Differential Revision: D46892454
fbshipit-source-id: 3afadcdd75969c2589bbb06f47d1c4c1c2690abd
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Dec 19, 2023
@analysis-bot

analysis-bot commented Dec 19, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,492,703-8,032,431
androidhermesarmeabi-v7a7810696n/a
androidhermesx868962699n/a
androidhermesx86_648824119n/a
androidjscarm64-v8a9,151,439-10,748,510
androidjscarmeabi-v7a8341136n/a
androidjscx869204613n/a
androidjscx86_649463438n/a

Base commit: 1045b22
Branch: main

@fortmarek
fortmarek merged commit c3c6cf4 into 0.72-stableDec 19, 2023
@fortmarek
fortmarek deleted the fortmarek/prevent-log-box branch December 19, 2023 13:55
This was referenced Dec 27, 2023
Merged
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschicipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschicipolleschicipolleschi approved these changes

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: ShopifyPartner: ShopifyPartnerPick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fortmarek@analysis-bot@cipolleschi@facebook-github-bot@motiz88