Uh oh!
There was an error while loading. Please reload this page.
feat: add --custom-resolver-options to bundle command - #42333
Closed
szymonrybczak wants to merge 2 commits into
Closed
feat: add --custom-resolver-options to bundle command#42333szymonrybczak wants to merge 2 commits into
--custom-resolver-options to bundle command#42333szymonrybczak wants to merge 2 commits into
Conversation
szymonrybczak
commented
Jan 17, 2024
ContributorAuthor
cc @huntie |
Uh oh!
There was an error while loading. Please reload this page.
szymonrybczakforce-pushed
the
feat/cli/add-resolver-option
branch
from
January 17, 2024 14:35
ef58a47 to
f474186Compare--resolver-options to bundle command--custom-resolver-options to bundle commandhuntie
reviewed
Jan 17, 2024
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Hunt <hello@alexhunt.io>
facebook-github-bot
commented
Jan 18, 2024
Contributor
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jan 18, 2024
Contributor
facebook-github-bot pushed a commit
that referenced
this pull request
Jan 22, 2024
Summary: Pull Request resolved: #42392 Follow-up to #42333 following internal feedback. We are now aligning this to match the [`metro build` command](https://github.com/facebook/metro/blob/702e1b8fc7ab8b973bcd53f1a41f7e797cbf7dca/packages/metro/src/commands/build.js#L85-L91). This also improves validation on parsing (done after initial `commander` arg parsing as variadic string). Changelog: [Internal] (same as #42333) Reviewed By: motiz88 Differential Revision: D52911017 fbshipit-source-id: 54049aa20c9db344a0f485fddf62fb267e672376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added
--custom-resolver-optionsto--bundlecommand. This options is also available in Metro's CLI.Changelog:
[INTERNAL] [ADDED] - Add
--resolver-optionstobundlecommandTest Plan:
yarn buildin the rootpackages/rn-testerand runnpx react-native bundle --custom-resolver-options key=valueand the options should be passed to the Config.