Uh oh!
There was an error while loading. Please reload this page.
Align parsing of custom resolver options, rename arg - #42392
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Jan 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
huntie
commented
Jan 19, 2024
CollaboratorAuthor
facebook-github-bot
commented
Jan 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
Base commit: a89005d |
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
1 similar comment
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
1 similar comment
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
Summary: Pull Request resolved: #42392 Follow-up to #42333 following internal feedback. We are now aligning this to match the [`metro build` command](https://github.com/facebook/metro/blob/702e1b8fc7ab8b973bcd53f1a41f7e797cbf7dca/packages/metro/src/commands/build.js#L85-L91). This also improves validation on parsing (done after initial `commander` arg parsing as variadic string). Changelog: [Internal] (same as #42333) Reviewed By: motiz88 Differential Revision: D52911017 fbshipit-source-id: e3c9c3b82b1ae58fb82ab2cb31adf78775c18916
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D52911017 |
facebook-github-bot
commented
Jan 22, 2024
Contributor
This pull request has been merged in 4e92f87. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to #42333 following internal feedback. We are now aligning this to match the
metro buildcommand. This also improves validation on parsing (done after initialcommanderarg parsing as variadic string).Changelog: [Internal]
(same as #42333)
Reviewed By: motiz88
Differential Revision: D52911017