Skip to content

Avoid using Cocoapods 1.15 until it fixes an issue affection RN. - #42702

Closed
blakef wants to merge 1 commit into
mainfrom
fix-limit-cocoapods
Closed

Avoid using Cocoapods 1.15 until it fixes an issue affection RN.#42702
blakef wants to merge 1 commit into
mainfrom
fix-limit-cocoapods

Conversation

@blakef

Copy link
Copy Markdown
Contributor

Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15

Summary:

This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.

Changelog:

[iOS][Fixed] don't allow cocoapods 1.15.

Test Plan:

bundle exec pod install

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 29, 2024
Summary:
Users aren't able to build (#42698). We're restricting the version to known
good version of Cocoapods until the next release.
Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
@blakef
blakefforce-pushed the fix-limit-cocoapods branch from 831ba71 to 91125b0CompareJanuary 29, 2024 11:32
@blakefblakef changed the title Create a test that Expo's nightlies trigger with an outcomeAvoid using Cocoapods 1.15 until it fixes an issue affection RN.Jan 29, 2024
@cipolleschi

Copy link
Copy Markdown
Contributor

Good job, thanks for doing this!

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a17,066,830-2
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a20,450,428-4
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: cfc0ba0
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Jan 29, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@blakef merged this pull request in 3869ae4.

blakef added a commit that referenced this pull request Jan 29, 2024
)
Summary:
Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
[iOS][Fixed] don't allow cocoapods 1.15.
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: #42702
Test Plan:
```
bundle exec pod install
```
Reviewed By: cipolleschi
Differential Revision: D53180111
Pulled By: blakef
fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
huntie pushed a commit that referenced this pull request Jan 29, 2024
)
Summary:
Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
## Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
hurali97 added a commit that referenced this pull request Jan 29, 2024
)
Summary:
Cocoapods 1.15 (#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
[iOS][Fixed] don't allow cocoapods 1.15.
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: #42702
Test Plan:
```
bundle exec pod install
```
Reviewed By: cipolleschi
Differential Revision: D53180111
Pulled By: blakef
fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
@IronTony

IronTony commented Jan 29, 2024

Copy link
Copy Markdown

It's currently blocking 0.73.3

Not only. This blocks also 0.72.6. I think this is a general problem

hurali97 added a commit that referenced this pull request Jan 29, 2024
Cherry-picking 'Avoid using Cocoapods 1.15 until it fixes an issue affection RN. (#42702)' onto 0.71
@blakef
blakef deleted the fix-limit-cocoapods branch January 29, 2024 23:43
blakef added a commit to blakef/template that referenced this pull request Feb 28, 2024
…702)
Summary:
Cocoapods 1.15 (react/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
## Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: react/react-native#42702
Test Plan:
```
bundle exec pod install
```
Reviewed By: cipolleschi
Differential Revision: D53180111
Pulled By: blakef
fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
Original: react/react-native@3869ae4
blakef added a commit to react-native-community/template that referenced this pull request Feb 29, 2024
…702)
Summary:
Cocoapods 1.15 (react/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
## Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: react/react-native#42702
Test Plan:
```
bundle exec pod install
```
Reviewed By: cipolleschi
Differential Revision: D53180111
Pulled By: blakef
fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
Original-Commit: react/react-native@3869ae4
blakef added a commit to react-native-community/template that referenced this pull request Feb 29, 2024
…702)
Summary:
Cocoapods 1.15 (react/react-native#42698) current breaks the build, limit to version >= 1.13 & < 1.15
This is currently broken and affecting users, we'll remove this limit once Cocopods fixes the regression. It's currently blocking 0.73.3.
## Changelog:
[iOS][Fixed] don't allow cocoapods 1.15.
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: react/react-native#42702
Test Plan:
```
bundle exec pod install
```
Reviewed By: cipolleschi
Differential Revision: D53180111
Pulled By: blakef
fbshipit-source-id: 4c5dd11db6d208e8d71249443a8f85e601913abd
Original-Commit: react/react-native@3869ae4
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.MergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@blakef@cipolleschi@analysis-bot@facebook-github-bot@IronTony