Uh oh!
There was an error while loading. Please reload this page.
[Android] MapBuffer long support - #43030
Conversation
b069237 to
03fe402Compare
Base commit: 4ecf57e |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
facebook-github-bot
commented
Feb 17, 2024
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
left a comment
There was a problem hiding this comment.
Left a comment, where someone else noticed the same long to double issue in another file. Was also raised that we should ideally have new tests for each of the structures we are editing, for these scenarios, like the truncation one.
Uh oh!
There was an error while loading. Please reload this page.
ryanlntn
commented
Feb 20, 2024
@NickGerleman I dropped the bridge changes to keep this completely focused on MapBuffer. |
facebook-github-bot
commented
Feb 22, 2024
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Feb 28, 2024
@NickGerleman merged this pull request in 57ed0fb. |
Summary:
This adds support for 64 bit integer (long) values to MapBuffer. Per the wide gamut color RFC Android encodes wide gamut colors as long values so we need to update MapBuffer to support 64 bit integers as well.
Changelog:
[ANDROID] [ADDED] - Add 64 bit integer (long) value support to MapBuffer
Test Plan:
I've added a test to the MapBuffer test suite. This new API is otherwise currently unused but will be used in subsequent PRs as part of wide gamut color support changes.