Uh oh!
There was an error while loading. Please reload this page.
[Android] Update HostPlatformColor to support color longs - #43163
[Android] Update HostPlatformColor to support color longs#43163ryanlntn wants to merge 2 commits into
Conversation
8a65961 to
e0d99c3Comparefacebook-github-bot
commented
Apr 4, 2024
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
commented
Apr 17, 2024
Could we document what the magic numbers are doing? Maybe pull them out into constants? |
e0d99c3 to
61ea51dCompareryanlntn
commented
Apr 17, 2024
@NickGerleman I pulled out the color space and component ratios definitions into constants. Should I do similar with the bit masks/shifts? I can't decide what's more readable. |
analysis-bot
commented
Apr 17, 2024
Base commit: fe9942a |
NickGerleman
commented
Apr 18, 2024
The shifts seem reasonably readable to me |
facebook-github-bot
commented
Apr 22, 2024
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
react-native-bot
commented
Oct 20, 2024
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
commented
Oct 27, 2024
This PR was closed because it has been stalled for 7 days with no activity. |
Summary:
This adds support for color longs to HostPlatformColor per the wide gamut color RFC.
Changelog:
[ANDROID] [ADDED] - Update HostPlatformColor to support color longs
Test Plan:
This requires changes from #43030 to build and will only break text color until those components are updated to support color long values as well. Will update with a link to that PR soon.