Uh oh!
There was an error while loading. Please reload this page.
[Android] Update ColorPropConverterto support color function values - #43031
Closed
ryanlntn wants to merge 1 commit into
Closed
[Android] Update ColorPropConverterto support color function values#43031ryanlntn wants to merge 1 commit into
ryanlntn wants to merge 1 commit into
Conversation
ryanlntnforce-pushed
the
feat/wide-gamut-color-prop-converter
branch
from
February 14, 2024 20:28
ec5415e to
ef1add6Compareanalysis-bot
commented
Feb 14, 2024
Base commit: 7b00a92 |
This was referenced Feb 23, 2024
ryanlntnforce-pushed
the
feat/wide-gamut-color-prop-converter
branch
from
March 15, 2024 01:14
ef1add6 to
e486395Compareryanlntnforce-pushed
the
feat/wide-gamut-color-prop-converter
branch
from
March 15, 2024 10:33
e486395 to
53300f7Comparefacebook-github-bot
commented
Apr 4, 2024
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Apr 23, 2024
Contributor
@cipolleschi merged this pull request in fa7dbd5. |
This pull request was successfully merged by @ryanlntn in fa7dbd5. When will my fix make it into a release? | How to file a pick request? |
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: This adds support for color function values to ColorPropConverter per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed. bypass-github-export-checks ## Changelog: [ANDROID] [ADDED] - Update ColorPropConverter to support color function values Pull Request resolved: react#43031 Test Plan: Colors should work exactly the same as before. Follow test steps from react#42831 to test support for color() function syntax. While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values. Reviewed By: cortinico Differential Revision: D55749058 Pulled By: cipolleschi fbshipit-source-id: 37659d22c1db4b1a27a9a4f88c9beb703517b01f
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…eact#44225) Summary: Pull Request resolved: react#44225 Back out [react#43031](react#43031) as it makes some internal test fails. ## Changelog: [Android][Fixed] - Revert react#43031 Reviewed By: arushikesarwani94 Differential Revision: D56489260 fbshipit-source-id: bd843e6eb60fce0a1d5d8da9f3c5d2a36473ecfb
facebook-github-bot pushed a commit
that referenced
this pull request
May 20, 2024
Summary: Pull Request resolved: #44237 This adds support for color function values to ColorPropConverter per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed. ## Changelog: [ANDROID] [ADDED] - Update ColorPropConverter to support color function values Pull Request resolved: #43031 Test Plan: Colors should work exactly the same as before. Follow test steps from #42831 to test support for color() function syntax. While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values. --- After the failure with the tests, I reapplied the changes and test some Jest e2e tests that were failing yesterday: {F1495277376} Reviewed By: cortinico Differential Revision: D56517579 Pulled By: cipolleschi fbshipit-source-id: ae9b5bc2afe9eb9760dd91afb090385daf7102b8
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: This adds support for color function values to ColorPropConverter per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed. bypass-github-export-checks ## Changelog: [ANDROID] [ADDED] - Update ColorPropConverter to support color function values Pull Request resolved: react#43031 Test Plan: Colors should work exactly the same as before. Follow test steps from react#42831 to test support for color() function syntax. While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values. Reviewed By: cortinico Differential Revision: D55749058 Pulled By: cipolleschi fbshipit-source-id: 37659d22c1db4b1a27a9a4f88c9beb703517b01f
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…eact#44225) Summary: Pull Request resolved: react#44225 Back out [react#43031](react#43031) as it makes some internal test fails. ## Changelog: [Android][Fixed] - Revert react#43031 Reviewed By: arushikesarwani94 Differential Revision: D56489260 fbshipit-source-id: bd843e6eb60fce0a1d5d8da9f3c5d2a36473ecfb
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: react#44237 This adds support for color function values to ColorPropConverter per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed. ## Changelog: [ANDROID] [ADDED] - Update ColorPropConverter to support color function values Pull Request resolved: react#43031 Test Plan: Colors should work exactly the same as before. Follow test steps from react#42831 to test support for color() function syntax. While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values. --- After the failure with the tests, I reapplied the changes and test some Jest e2e tests that were failing yesterday: {F1495277376} Reviewed By: cortinico Differential Revision: D56517579 Pulled By: cipolleschi fbshipit-source-id: ae9b5bc2afe9eb9760dd91afb090385daf7102b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for color function values to ColorPropConverter per the wide gamut color RFC. It updates the color conversion code so that it returns a Color instance before ultimately being converted to an Integer in preparation for returning long values as needed.
Changelog:
[ANDROID] [ADDED] - Update ColorPropConverter to support color function values
Test Plan:
Colors should work exactly the same as before.
Follow test steps from #42831 to test support for color() function syntax.
While colors specified with color() function syntax will not yet render in DisplayP3 color space they will not be misrecognized as resource path colors but will instead fallback to their sRGB color space values.