Skip to content

[Android] update scroll views to support wide gamut color - #43197

Closed
ryanlntn wants to merge 2 commits into
react:mainfrom
ryanlntn:feat/wide-gamut-color-android-scrollview
Closed

[Android] update scroll views to support wide gamut color#43197
ryanlntn wants to merge 2 commits into
react:mainfrom
ryanlntn:feat/wide-gamut-color-android-scrollview

Conversation

@ryanlntn

@ryanlntnryanlntn commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Summary:

This builds on previous PRs for the wide gamut color RFC and extends Android scroll views with support for DisplayP3 color.

Changelog:

[ANDROID] [ADDED] - update scroll views to support wide gamut color

Test Plan:

  1. Pull changes from these previous PRs:
    [JS] Add support for CSS4 color() functions #42831
    [Android] Update ColorPropConverterto support color function values #43031
    [Android] Add isWideColorGamutEnabled to ReactActivityDelegate #43036
    [Android] Add DisplayP3 background and border support to View #43056
  2. Follow the test steps for each PR
  3. Pull these changes and build RNTester for Android: cd packages/rn-tester && yarn android
  4. Navigate to ScrollViewExample and modify to set DisplayP3 background/borders/endFill

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Infinite Red Partner: Infinite Red Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 26, 2024
@ryanlntn
ryanlntnforce-pushed the feat/wide-gamut-color-android-scrollview branch 2 times, most recently from eeb6432 to 42778aaCompareMarch 15, 2024 10:35
@facebook-github-bot

facebook-github-bot commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot

facebook-github-bot commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

NickGerleman
NickGerleman reviewed Apr 6, 2024
View reviewed changes
Comment thread...ve/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java Outdated

@NickGerlemanNickGerlemanApr 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, since we are now comparing int color to packed color long.

@ryanlntnryanlntnApr 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in this case they both evaluate to 0L but I'll update to make it explicit.

Comment thread...react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java Outdated

@NickGerlemanNickGerlemanApr 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do this if we are creating mEndBackground from new color?

@ryanlntnryanlntnApr 8, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oversight. I meant to remove mEndBackground as we need to draw on the canvas directly in order to use paint.

@cipolleschi

cipolleschi commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

/rebase

@github-actions
github-actionsBotforce-pushed the feat/wide-gamut-color-android-scrollview branch from cfbfc83 to 07105c3CompareApril 10, 2024 11:23
@react-native-bot

react-native-bot commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-botreact-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 8, 2024
@cipolleschi

cipolleschi commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

do not close

@react-native-botreact-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 11, 2024
@react-native-bot

react-native-bot commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-botreact-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 14, 2025
@react-native-bot

react-native-bot commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

This PR was closed because it has been stalled for 7 days with no activity.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@NickGerlemanNickGerlemanNickGerleman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: Infinite RedPartner: Infinite RedPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.StaleThere has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ryanlntn@facebook-github-bot@cipolleschi@react-native-bot@NickGerleman