Uh oh!
There was an error while loading. Please reload this page.
Small refactor in RuntimeScheduler_Modern to favor references over shared_ptr for non-owning function args - #43852
Closed
rubennorte wants to merge 6 commits into
Closed
Small refactor in RuntimeScheduler_Modern to favor references over shared_ptr for non-owning function args#43852rubennorte wants to merge 6 commits into
rubennorte wants to merge 6 commits into
Conversation
facebook-github-bot
commented
Apr 4, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
from
April 4, 2024 14:21
800c3db to
735071aComparefacebook-github-bot
commented
Apr 4, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
1 similar comment
facebook-github-bot
commented
Apr 4, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
2 times, most recently
from
April 5, 2024 10:48
8cebfe6 to
dc42b41Comparefacebook-github-bot
commented
Apr 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
Base commit: 2fcdab4 |
facebook-github-bot
commented
Apr 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
from
April 5, 2024 14:04
dc42b41 to
49fedaaComparefacebook-github-bot
commented
Apr 5, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
from
April 5, 2024 14:13
49fedaa to
56322d9Comparefacebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
2 times, most recently
from
April 9, 2024 11:07
c70d6b2 to
65d888eComparefacebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
1 similar comment
facebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
2 times, most recently
from
April 9, 2024 11:21
aeb1950 to
1e85043Comparefacebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
Differential Revision: D55646390
Differential Revision: D55646393
Differential Revision: D55646394
Differential Revision: D55646391
Differential Revision: D55646392
facebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorteforce-pushed
the
export-D55646389
branch
from
April 9, 2024 11:29
1e85043 to
458e874Comparefacebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request has been merged in d35de2d. |
Titozzz pushed a commit
that referenced
this pull request
Jun 18, 2024
…ared_ptr for non-owning function args (#43852) Summary: Pull Request resolved: #43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389 fbshipit-source-id: d01dcba7b1551d349d21717ba585828ed7fb3259
Titozzz pushed a commit
that referenced
this pull request
Jun 18, 2024
…ared_ptr for non-owning function args (#43852) Summary: Pull Request resolved: #43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389 fbshipit-source-id: d01dcba7b1551d349d21717ba585828ed7fb3259
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just a small refactor so we rely less on shared pointers within
RuntimeSCheduler_Modern.Differential Revision: D55646389