Uh oh!
There was an error while loading. Please reload this page.
Refactor: RuntimeScheduler: Delete ErrorUtils.h - #43953
Closed
RSNara wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
Base commit: f77d028 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 7, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
Summary: getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering. This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle. I filed a task for the investigation to see if there's any problems. And added it to the code in this diff. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547899
Summary: RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905
facebook-github-bot
commented
Apr 8, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D55547905 |
RSNara added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905
RSNara added a commit
to RSNara/react-native
that referenced
this pull request
Apr 8, 2024
Summary: RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905
facebook-github-bot
commented
Apr 9, 2024
Contributor
This pull request has been merged in 3094273. |
Titozzz pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: Pull Request resolved: #43953 RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905 fbshipit-source-id: 5263c9fca8ae32bbfc672f0e16b79ee177cdd421
Titozzz pushed a commit
that referenced
this pull request
Jun 18, 2024
Summary: Pull Request resolved: #43953 RuntimeScheduler's ErrorUtils.h is redundant. Let's just remove it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55547905 fbshipit-source-id: 5263c9fca8ae32bbfc672f0e16b79ee177cdd421
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RuntimeScheduler's ErrorUtils.h is redundant.
Let's just remove it.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D55547905