Uh oh!
There was an error while loading. Please reload this page.
Fallback to the first foregroundInactive window when there are no foregroundActive windows in RCTKeyWindow - #44167
Closed
cipolleschi wants to merge 1 commit into
Closed
Fallback to the first foregroundInactive window when there are no foregroundActive windows in RCTKeyWindow#44167cipolleschi wants to merge 1 commit into
foregroundInactive window when there are no foregroundActive windows in RCTKeyWindow#44167cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Apr 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56354741 |
…foregroundActive` windows in RCTKeyWindow (#44167) Summary: We received an issue for OSS where, when the main window is inactive and the system tries to present a dialog, the dialog is not presented in the right position on the screen. This change introduce a fallback to the first inactive window (which is still visible on screen) and it fixes the issues. ## Changelog: [iOS][Changed] - Fallback to the first `foregroundInactive` window when there are no `foregroundActive` windows in RCTKeyWindow Differential Revision: D56354741
cipolleschiforce-pushed
the
export-D56354741
branch
2 times, most recently
from
April 19, 2024 14:26
0091783 to
17da3ceComparefacebook-github-bot
commented
Apr 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56354741 |
1 similar comment
facebook-github-bot
commented
Apr 19, 2024
Contributor
This pull request was exported from Phabricator. Differential Revision: D56354741 |
facebook-github-bot
commented
Apr 25, 2024
Contributor
This pull request has been merged in 42ceacd. |
This pull request was successfully merged by @cipolleschi in 42ceacd. When will my fix make it into a release? | How to file a pick request? |
cipolleschi added a commit
that referenced
this pull request
May 1, 2024
…foregroundActive` windows in RCTKeyWindow (#44167) Summary: Pull Request resolved: #44167 We received an issue for OSS where, when the main window is inactive and the system tries to present a dialog, the dialog is not presented in the right position on the screen. This change introduce a fallback to the first inactive window (which is still visible on screen) and it fixes the issues. [iOS][Changed] - Fallback to the first `foregroundInactive` window when there are no `foregroundActive` windows in RCTKeyWindow Reviewed By: dmytrorykun Differential Revision: D56354741 fbshipit-source-id: fa23131ecd40f6d91c705879a72890506ee21486
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
…foregroundActive` windows in RCTKeyWindow (react#44167) Summary: Pull Request resolved: react#44167 We received an issue for OSS where, when the main window is inactive and the system tries to present a dialog, the dialog is not presented in the right position on the screen. This change introduce a fallback to the first inactive window (which is still visible on screen) and it fixes the issues. ## Changelog: [iOS][Changed] - Fallback to the first `foregroundInactive` window when there are no `foregroundActive` windows in RCTKeyWindow Reviewed By: dmytrorykun Differential Revision: D56354741 fbshipit-source-id: fa23131ecd40f6d91c705879a72890506ee21486
kosmydel pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…foregroundActive` windows in RCTKeyWindow (react#44167) Summary: Pull Request resolved: react#44167 We received an issue for OSS where, when the main window is inactive and the system tries to present a dialog, the dialog is not presented in the right position on the screen. This change introduce a fallback to the first inactive window (which is still visible on screen) and it fixes the issues. ## Changelog: [iOS][Changed] - Fallback to the first `foregroundInactive` window when there are no `foregroundActive` windows in RCTKeyWindow Reviewed By: dmytrorykun Differential Revision: D56354741 fbshipit-source-id: fa23131ecd40f6d91c705879a72890506ee21486
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We received an issue for OSS where, when the main window is inactive and the system tries to present a dialog, the dialog is not presented in the right position on the screen.
This change introduce a fallback to the first inactive window (which is still visible on screen) and it fixes the issues.
Changelog:
[iOS][Changed] - Fallback to the first
foregroundInactivewindow when there are noforegroundActivewindows in RCTKeyWindowDifferential Revision: D56354741