Uh oh!
There was an error while loading. Please reload this page.
Support customizeRootView from RCTRootViewFactory - #44775
Conversation
Base commit: bb61e07 |
cipolleschi
commented
Jun 4, 2024
Thanks for the PR, but I don't think we need this, @Kudo. We moved the Perhaps I'm missing something, but why we need to bring this customization into the RootView Factory? |
Kudo
commented
Jun 4, 2024
@cipolleschi thanks for feedback. this is to resolve the issue when enable new architecture with react-native-bootsplash and expo-updates. there is a workaround patch in react-conf-app but i think it would be good to have the feature in RCTRootViewFactory, so that developers reuse RCTRootViewFactory can fully support customizeRootView. we could apply the patch inside expo-modules-core if you think RCTRootViewFactory is not the right place. more details: expo-updates will delay the timing to initialize react instance and create an empty root view rather than the RCTRootView. we need to show splash screen twice. one before empty root view and the other after we use RCTRootViewFactory to create the formal RCTRootView. react-native-bootsplash uses customizeRootView to setup and show splash screen twice. that's why we need customizeRootView to be supported from RCTRootViewFactory (or our derived EXReactRootViewFactory) |
4d2aedb to
8b54ed7Compare
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for the contribution and the explanation!
facebook-github-bot
commented
Jun 5, 2024
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Jun 6, 2024
@cipolleschi merged this pull request in 8956869. |
This pull request was successfully merged by @Kudo in 8956869. When will my fix make it into a release? | How to file a pick request? |
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. ## Changelog: [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: react#44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: #44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
Summary: The new `customizeRootView` does not have the feature parity as `createRootViewWithBridge` where reusing RCTRootViewFactory to create a root view, it does not call `customizeRootView`. This PR moves the `customizeRootView` support from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support. [IOS] [CHANGED] - Support `customizeRootView` from `RCTRootViewFactory` Pull Request resolved: #44775 Test Plan: Add customizeRootView to **packages/rn-tester/RNTester/AppDelegate.mm** and test whether RNTester has blue background color in both new arch and old arch mode. ```objc - (void)customizeRootView:(RCTRootView *)rootView { rootView.backgroundColor = [UIColor blueColor]; } ``` Reviewed By: dmytrorykun Differential Revision: D58179693 Pulled By: cipolleschi fbshipit-source-id: 0fac9a1bd5b2583a2700b3a3d2c80d0f608c4481
zoontek
commented
Jun 28, 2024
@cipolleschi@Kudo Does a 0.74.x version with this fix is planned? |
Kudo
commented
Jun 28, 2024
yes, it was already picked reactwg/react-native-releases#312, would be available from next version |
# Why react-native 0.74.3 added `customizeRootView` support from react/react-native#44775. we should clone the code from `RCTAppDelegate.createRCTRootViewFactory` to our `EXAppDelegateWrapper.createRCTRootViewFactory` that could possibly fix react-native-bootsplash integration for zoontek/react-native-bootsplash#590 # How - reference https://github.com/facebook/react-native/blob/8c8c77b974ce3d4c3036361e56276a6ff2b02208/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L238-L262 to copy to `EXAppDelegateWrapper.createRCTRootViewFactory` - since we are still on 0.74.2, we should use `respondsToSelector` to check the existing property from RCTRootViewFactoryConfiguration.
react-native 0.74.3 added `customizeRootView` support from react/react-native#44775. we should clone the code from `RCTAppDelegate.createRCTRootViewFactory` to our `EXAppDelegateWrapper.createRCTRootViewFactory` that could possibly fix react-native-bootsplash integration for zoontek/react-native-bootsplash#590 - reference https://github.com/facebook/react-native/blob/8c8c77b974ce3d4c3036361e56276a6ff2b02208/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L238-L262 to copy to `EXAppDelegateWrapper.createRCTRootViewFactory` - since we are still on 0.74.2, we should use `respondsToSelector` to check the existing property from RCTRootViewFactoryConfiguration. (cherry picked from commit 7c7499a)
Summary:
The new
customizeRootViewdoes not have the feature parity ascreateRootViewWithBridgewhere reusing RCTRootViewFactory to create a root view, it does not callcustomizeRootView. This PR moves thecustomizeRootViewsupport from RCTAppDelegate into RCTRootViewFactory and improves the customizeRootView support.Changelog:
[IOS] [CHANGED] - Support
customizeRootViewfromRCTRootViewFactoryTest Plan:
Add customizeRootView to packages/rn-tester/RNTester/AppDelegate.mm and test whether RNTester has blue background color in both new arch and old arch mode.