Skip to content

[RN][CI] Zip slices to preserve symlinks - #46301

Merged
cipolleschi merged 1 commit into
0.75-stablefrom
cipolleschi/fix-symlinks
Sep 11, 2024
Merged

[RN][CI] Zip slices to preserve symlinks#46301
cipolleschi merged 1 commit into
0.75-stablefrom
cipolleschi/fix-symlinks

Conversation

@cipolleschi

@cipolleschicipolleschi commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Summary:

This change should fix#46213. We are trying to zip the folders generated by the CI and to upload the zip files as artifacts.

The zip should preserve the symlink and Github actions should not manipulate them.

Changelog:

[Internal] - Zip slices on CI to preserve symlinks

Test Plan:

GHA

@cipolleschi
cipolleschi changed the base branch from main to 0.75-stableSeptember 2, 2024 14:18
@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 2, 2024
@react-native-bot

Copy link
Copy Markdown
Collaborator
Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against eda7be92a54dad39d4ebc22fb64d5df96227ee60

@analysis-bot

analysis-bot commented Sep 2, 2024

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a20,743,782-611,074
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a23,945,530-604,461
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: fcd526d
Branch: main

@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-symlinks branch from c17e42e to 117cdbcCompareSeptember 3, 2024 11:48
@cipolleschi
cipolleschi marked this pull request as ready for review September 3, 2024 11:57
@cipolleschi
cipolleschiforce-pushed the cipolleschi/fix-symlinks branch from 117cdbc to 9e98346CompareSeptember 8, 2024 11:58
@cipolleschi
cipolleschi merged commit 8c732dd into 0.75-stableSep 11, 2024
@cipolleschi
cipolleschi deleted the cipolleschi/fix-symlinks branch September 11, 2024 09:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cipolleschi@react-native-bot@analysis-bot@facebook-github-bot