Uh oh!
There was an error while loading. Please reload this page.
refactor(community-cli-plugin): use node builtin fetch - #47397
Closed
jbroma wants to merge 1 commit into
Closed
Conversation
thymikee
left a comment
Contributor
There was a problem hiding this comment.
👍. Any way we can help advance this?
facebook-github-bot
commented
Nov 26, 2024
Contributor
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
commented
Nov 27, 2024
Contributor
@NickGerleman merged this pull request in 881d8a7. |
react-native-bot
commented
Nov 27, 2024
Collaborator
This pull request was successfully merged by @jbroma in 881d8a7 When will my fix make it into a release? | How to file a pick request? |
robhogan pushed a commit
that referenced
this pull request
Dec 2, 2024
Summary: Removed `node-fetch` in favour of node builtin fetch to get rid of the deprecated `punycode` warning when using Node 22. `react-native/community-cli-plugin` already requires Node >= 18 where it was made available by default (without `--experimental-fetch` flag). This change is similar to the one made in #45227 ## Changelog: [GENERAL] [CHANGED] - Drop node-fetch in favor of Node's built-in fetch from undici in `react-native/community-cli-plugin` Pull Request resolved: #47397 Test Plan: tests pass Reviewed By: blakef Differential Revision: D66512595 Pulled By: NickGerleman fbshipit-source-id: c4e01baf388f9fae8cea7b4bfe25034bff28b461
react-native-bot
commented
Dec 2, 2024
Collaborator
This pull request was successfully merged by @jbroma in 184da89 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removed
node-fetchin favour of node builtin fetch to get rid of the deprecatedpunycodewarning when using Node 22.@react-native/community-cli-pluginalready requires Node >= 18 where it was made available by default (without--experimental-fetchflag).This change is similar to the one made in #45227
Changelog:
[GENERAL] [CHANGED] - Drop node-fetch in favor of Node's built-in fetch from undici in
@react-native/community-cli-pluginTest Plan:
tests pass