Uh oh!
There was an error while loading. Please reload this page.
RuntimeExecutor: Remove noexcept from sync ui thread utils - #51514
Closed
RSNara wants to merge 2 commits into
Closed
RuntimeExecutor: Remove noexcept from sync ui thread utils#51514RSNara wants to merge 2 commits into
RSNara wants to merge 2 commits into
Conversation
facebook-github-bot
commented
May 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
facebook-github-bot
commented
May 22, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
RSNaraforce-pushed
the
export-D75183993
branch
2 times, most recently
from
May 23, 2025 19:33
6caf8fe to
71eb0bcComparefacebook-github-bot
commented
May 23, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
facebook-github-bot
commented
May 23, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
RSNara added a commit
to RSNara/react-native
that referenced
this pull request
May 24, 2025
Summary: Pull Request resolved: react#51514 This util can execute arbitrary runtimeWork, which can throw. In the future, we'll also make these utils execute ui blocks posted from the javascript thread. And those will be able to throw. Therefore, let's remove the noexcept. Otherwise, if an exception bubbles up to this util, it will just crash this app. Changelog: [General][Changed] - RuntimeExecutor: Remove noexcept from sync ui thread utils Differential Revision: D75183993 Reviewed By: javache
facebook-github-bot
commented
May 24, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
Summary: Pull Request resolved: react#51429 If we use promises, I believe the code is just easier to understand. Changelog: [Internal] Differential Revision: D74941734
Summary: Pull Request resolved: react#51514 This util can execute arbitrary runtimeWork, which can throw. In the future, we'll also make these utils execute ui blocks posted from the javascript thread. And those will be able to throw. Therefore, let's remove the noexcept. Otherwise, if an exception bubbles up to this util, it will just crash this app. Changelog: [General][Changed] - RuntimeExecutor: Remove noexcept from sync ui thread utils Reviewed By: javache Differential Revision: D75183993
facebook-github-bot
commented
May 27, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D75183993 |
facebook-github-bot
commented
May 27, 2025
Contributor
This pull request has been merged in 7ef278a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the future, we'll also make these utils execute ui blocks posted from the javascript thread. And those will be able to throw.
Changelog: [General][Changed] - RuntimeExecutor: Remove noexcept from sync ui thread utils
Differential Revision: D75183993