Uh oh!
There was an error while loading. Please reload this page.
Cover react/nativemodule/featureflags with Stable API guards - #58041
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/nativemodule/featureflags with Stable API guards#58041j-piasecki wants to merge 1 commit into
react/nativemodule/featureflags with Stable API guards#58041j-piasecki wants to merge 1 commit into
Conversation
Summary: Classifies `react/nativemodule/featureflags:featureflags` as a private target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its header directly; without that flag the guard is inert, so no existing build changes behaviour. `NativeReactNativeFeatureFlags.h` is generated, so the guard is added to its template and the file regenerated with `yarn featureflags --update` rather than edited in place. Changelog: [Internal] Differential Revision: D116916158
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116916158. |
This pull request has been merged in 6e7d5bf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/nativemodule/featureflags:featureflagsas a private target under the three-tier C++ stable API visibility model. Consumers that opt intoRN_STRICT_APInow get an error if they include its header directly; without that flag the guard is inert, so no existing build changes behaviour.NativeReactNativeFeatureFlags.his generated, so the guard is added to its template and the file regenerated withyarn featureflags --updaterather than edited in place.Changelog: [Internal]
Differential Revision: D116916158