Skip to content

Cover react/nativemodule/featureflags with Stable API guards#58041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Cover react/nativemodule/featureflags with Stable API guards #58041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/nativemodule/featureflags/CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_featureflags PUBLIC ${REACT_COMMON
target_link_libraries(react_nativemodule_featureflags
react_codegen_rncore
react_cxxreact
react_cxxstableapi
react_featureflags
)
target_compile_reactnative_options(react_nativemodule_featureflags PRIVATE)
Expand Down
4 changes: 3 additions & 1 deletion .../react-native/ReactCommon/react/nativemodule/featureflags/NativeReactNativeFeatureFlags.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c65d5fea853b54322321f86c1d5ce440>>
* @generated SignedSource<<40d25fafea07a23f9d4e146973c65cb5>>
*/

/**
Expand All@@ -19,6 +19,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
#include "FBReactNativeSpecJSI.h"
#else
Expand Down
1 change: 1 addition & 0 deletions ...native/ReactCommon/react/nativemodule/featureflags/React-featureflagsnativemodule.podspec
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,6 +50,7 @@ Pod::Spec.new do |s|
s.dependency "ReactCommon/turbomodule/core"
s.dependency "React-RCTFBReactNativeSpec"
s.dependency "React-featureflags"
s.dependency "React-cxxstableapi"

mark_as_react_native_build(s)
end
2 changes: 2 additions & 0 deletions ...eact-native/scripts/featureflags/templates/js/NativeReactNativeFeatureFlags.h-template.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,8 @@ ${DO_NOT_MODIFY_COMMENT}

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple
#include "FBReactNativeSpecJSI.h"
#else
Expand Down
Loading