Uh oh!
There was an error while loading. Please reload this page.
fix[devtools/e2e]: fixed source inspection in e2e tests - #28518
Merged
Conversation
EdmondChuiHW
approved these changes
Mar 7, 2024
| // Then read the inspected values. | ||
| const sourceText = await page.evaluate(() => { | ||
| const {createTestNameSelector, findAllNodes} = window.REACT_DOM_DEVTOOLS; |
Contributor
There was a problem hiding this comment.
Since this is an E2E test, is there a way to do this without reaching into the internals?
CollaboratorAuthor
There was a problem hiding this comment.
Yes, there is definitely a way to just use query selectors, but this is probably required for more complex cases with inputs
Internals are injected in
https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-shell/src/e2e/devtools.js#L60-L61
This was added in #22978, I think #22978 (comment) is one of the reasons.
gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
- react/react#28596 - react/react#28625 - react/react#28616 - react/react#28491 - react/react#28583 - react/react#28427 - react/react#28613 - react/react#28599 - react/react#28611 - react/react#28610 - react/react#28606 - react/react#28598 - react/react#28549 - react/react#28557 - react/react#28467 - react/react#28591 - react/react#28459 - react/react#28590 - react/react#28564 - react/react#28582 - react/react#28579 - react/react#28578 - react/react#28521 - react/react#28550 - react/react#28576 - react/react#28577 - react/react#28571 - react/react#28572 - react/react#28560 - react/react#28569 - react/react#28573 - react/react#28546 - react/react#28568 - react/react#28562 - react/react#28566 - react/react#28565 - react/react#28559 - react/react#28508 - react/react#20432 - react/react#28555 - react/react#24730 - react/react#28472 - react/react#27991 - react/react#28514 - react/react#28548 - react/react#28526 - react/react#28515 - react/react#28533 - react/react#28532 - react/react#28531 - react/react#28407 - react/react#28522 - react/react#28538 - react/react#28509 - react/react#28534 - react/react#28527 - react/react#28528 - react/react#28519 - react/react#28411 - react/react#28520 - react/react#28518 - react/react#28493 - react/react#28504 - react/react#28499 - react/react#28501 - react/react#28496 - react/react#28471 - react/react#28351 - react/react#28486 - react/react#28490 - react/react#28488 - react/react#28468 - react/react#28321 - react/react#28477 - react/react#28479 - react/react#28480 - react/react#28478 - react/react#28464 - react/react#28475 - react/react#28456 - react/react#28319 - react/react#28345 - react/react#28337 - react/react#28335 - react/react#28466 - react/react#28462 - react/react#28322 - react/react#28444 - react/react#28448 - react/react#28449 - react/react#28446 - react/react#28447 - react/react#24580
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
DevTools e2e tests started to fail after landing react#28471: - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798270 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798275 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798271 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798274 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798269 There are 2 reasons for that: 1. Versions 16.0 and 16.5 use legacy renderer, which doesn't support source inspection by design: https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-shared/src/backend/legacy/renderer.js#L831 The corresponding e2e test is now gated for versions >=16.8 2. For other versions (>=16.8), the source is actually `e2e-app-regression.js`, because these regression tests open a different page (not the one we open for tests against React from source) https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-inline/playwright.config.js#L15-L17
hoxyq added a commit
that referenced
this pull request
Apr 15, 2024
Full list of changes: * Look for a ReactMemoCacheSentinel on state ([gsathya](https://github.com/gsathya) in [#28831](#28831)) * Use use() in the Cache if available ([sebmarkbage](https://github.com/sebmarkbage) in [#28793](#28793)) * feat[devtools-fusebox]: support theme option ([hoxyq](https://github.com/hoxyq) in [#28832](#28832)) * feat[devtools]: add package for fusebox integration ([hoxyq](https://github.com/hoxyq) in [#28553](#28553)) * feat[devtools]: add method for connecting backend with custom messaging protocol ([hoxyq](https://github.com/hoxyq) in [#28552](#28552)) * Rename SECRET INTERNALS to `__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` ([sebmarkbage](https://github.com/sebmarkbage) in [#28789](#28789)) * Flatten ReactSharedInternals ([sebmarkbage](https://github.com/sebmarkbage) in [#28783](#28783)) * feat[devtools]: ship source maps for content scripts and ignore list installHook script ([hoxyq](https://github.com/hoxyq) in [#28730](#28730)) * Track Owner for Server Components in DEV ([sebmarkbage](https://github.com/sebmarkbage) in [#28753](#28753)) * Move ReactDOMLegacy implementation into RootFB ([sebmarkbage](https://github.com/sebmarkbage) in [#28656](#28656)) * Reland #28672: Remove IndeterminateComponent ([gnoff](https://github.com/gnoff) in [#28681](#28681)) * Remove reference to deleted <Cache> in un-linted file ([josephsavona](https://github.com/josephsavona) in [#28715](#28715)) * [be] Remove unshipped experimental <Cache> element type ([josephsavona](https://github.com/josephsavona) in [#28698](#28698)) * Revert "Remove module pattern function component support" ([rickhanlonii](https://github.com/rickhanlonii) in [#28670](#28670)) * Remove module pattern function component support ([gnoff](https://github.com/gnoff) in [#27742](#27742)) * [RTR] Enable warning flag ([jackpope](https://github.com/jackpope) in [#28419](#28419)) * Update error messages ([rickhanlonii](https://github.com/rickhanlonii) in [#28652](#28652)) * fix[devtools/ci]: split profiling cache test for different react versions and toEqual checker ([hoxyq](https://github.com/hoxyq) in [#28628](#28628)) * Guard against legacy context not being supported in DevTools fixture ([eps1lon](https://github.com/eps1lon) in [#28596](#28596)) * Use `declare const` instead of `declare var` ([kassens](https://github.com/kassens) in [#28599](#28599)) * Update isConcurrent RTR option usage ([jackpope](https://github.com/jackpope) in [#28546](#28546)) * Disable legacy context ([kassens](https://github.com/kassens) in [#27991](#27991)) * Remove invokeGuardedCallback and replay trick ([sebmarkbage](https://github.com/sebmarkbage) in [#28515](#28515)) * Remove remaining usages of ReactTestUtils in tests unrelated to `react-dom/test-util` ([eps1lon](https://github.com/eps1lon) in [#28534](#28534)) * fix[devtools/e2e]: fixed source inspection in e2e tests ([hoxyq](https://github.com/hoxyq) in [#28518](#28518)) * Devtools: Display actual pending state when inspecting `useTransition` ([eps1lon](https://github.com/eps1lon) in [#28499](#28499))
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
DevTools e2e tests started to fail after landing #28471: - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798270 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798275 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798271 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798274 - https://app.circleci.com/pipelines/github/facebook/react/50984/workflows/a7be25ed-9547-40e9-87bd-b14d9d2e87da/jobs/798269 There are 2 reasons for that: 1. Versions 16.0 and 16.5 use legacy renderer, which doesn't support source inspection by design: https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-shared/src/backend/legacy/renderer.js#L831 The corresponding e2e test is now gated for versions >=16.8 2. For other versions (>=16.8), the source is actually `e2e-app-regression.js`, because these regression tests open a different page (not the one we open for tests against React from source) https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-inline/playwright.config.js#L15-L17 DiffTrain build for commit 447fc27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevTools e2e tests started to fail after landing #28471:
There are 2 reasons for that:
https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-shared/src/backend/legacy/renderer.js#L831
The corresponding e2e test is now gated for versions >=16.8
2. For other versions (>=16.8), the source is actually
e2e-app-regression.js, because these regression tests open a different page (not the one we open for tests against React from source)https://github.com/facebook/react/blob/850fac4915864a487e7cb9ecae8a75dbac144174/packages/react-devtools-inline/playwright.config.js#L15-L17