Add alwaysThrottleDisappearingFallbacks Flag - #28550

Merged
yungsters merged 1 commit into
react:mainfrom
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged

Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom
yungsters:throttle-disappear-fallbacks

Conversation

@yungsters

@yungstersyungsters commented Mar 12, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.

This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.

How did you test this change?

$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot

react-sizebot commented Mar 12, 2024•
edited
Loading

Copy link
Copy Markdown

Comparing: 7959a1d...2cb6843

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843

@yungsters
yungstersforce-pushed the throttle-disappear-fallbacks branch from 314e8b5 to 68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii approved these changes Mar 18, 2024
View reviewed changes

@rickhanloniirickhanlonii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?

Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js Outdated
export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;

@rickhanloniirickhanloniiMar 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)

@yungsters

yungsters commented Mar 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Isn't it weird that no tests need updated?

I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.

@yungsters
yungstersforce-pushed the throttle-disappear-fallbacks branch from 68226dc to 0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters changed the title Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed the throttle-disappear-fallbacks branch from 0c08bc6 to 2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters merged commit 0aab065 into react:mainMar 18, 2024
@yungsters
yungsters deleted the throttle-disappear-fallbacks branch March 18, 2024 18:16
github-actionsBot pushed a commit that referenced this pull request Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner mentioned this pull request Mar 21, 2024
Closed
@gnoffgnoff mentioned this pull request Mar 25, 2024
Closed
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters mentioned this pull request Mar 25, 2024
Merged
yungsters added a commit that referenced this pull request Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot pushed a commit that referenced this pull request Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon mentioned this pull request Apr 19, 2024
Merged
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add alwaysThrottleDisappearingFallbacks Flag - #28550
Merged
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Mar 18, 2024
Merged
Add alwaysThrottleDisappearingFallbacks Flag#28550
yungsters merged 1 commit into
react:mainfrom 
yungsters:throttle-disappear-fallbacks
Conversation
@yungsters
@yungstersyungsters
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.
This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.
How did you test this change?
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

@react-sizebot
react-sizebot
commented
Mar 12, 2024•

edited

Loading

Copy link


Copy Markdown

Comparing: 7959a1d...2cb6843
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.min.js=176.83 kB176.83 kB=54.90 kB54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js=173.55 kB173.55 kB=54.11 kB54.11 kB
facebook-www/ReactDOM-prod.classic.js+0.02%594.16 kB594.27 kB+0.02%104.41 kB104.44 kB
facebook-www/ReactDOM-prod.modern.js+0.02%577.42 kB577.53 kB+0.02%101.45 kB101.47 kB
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
test_utils/ReactAllWarnings.jsDeleted66.63 kB0.00 kBDeleted16.28 kB0.00 kB

Generated by 🚫 dangerJS against 2cb6843
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
314e8b5 to
68226dcCompareMarch 13, 2024 22:30
rickhanlonii
rickhanlonii
approved these changes
Mar 18, 2024
View reviewed changes
@rickhanloniirickhanlonii
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird that no tests need updated?
Comment threadpackages/shared/forks/ReactFeatureFlags.www-dynamic.js
Outdated

export const enableTransitionTracing = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const alwaysThrottleRetries = __VARIANT__;
export const throttleDisappearingFallbacks = __VARIANT__;
@rickhanloniirickhanloniiMar 18, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)
@yungsters
yungsters
commented
Mar 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Isn't it weird that no tests need updated?
I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
68226dc to
0c08bc6CompareMarch 18, 2024 18:03
@yungstersyungsters
changed the title
Add throttleDisappearingFallbacks FlagAdd alwaysThrottleDisappearingFallbacks FlagMar 18, 2024
@yungsters
yungstersforce-pushed
the
throttle-disappear-fallbacks
branch
from
0c08bc6 to
2cb6843CompareMarch 18, 2024 18:06
@yungsters
yungsters
merged commit 0aab065
into
react:mainMar 18, 2024
@yungsters
yungsters
deleted the

throttle-disappear-fallbacks

branch
March 18, 2024 18:16
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
8cc2b72
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [0aab065](0aab065)
@ztannerztanner
mentioned this pull request
Mar 21, 2024
 Closed

@gnoffgnoff
mentioned this pull request
Mar 25, 2024
 Closed

gnoff added a commit
to gnoff/next.js
that referenced
this pull request
Mar 25, 2024
@gnoff
Update React from 14898b6a9 to e373190fa
1a2ce1f
- react/react#28596
- react/react#28625
- react/react#28616
- react/react#28491
- react/react#28583
- react/react#28427
- react/react#28613
- react/react#28599
- react/react#28611
- react/react#28610
- react/react#28606
- react/react#28598
- react/react#28549
- react/react#28557
- react/react#28467
- react/react#28591
- react/react#28459
- react/react#28590
- react/react#28564
- react/react#28582
- react/react#28579
- react/react#28578
- react/react#28521
- react/react#28550
- react/react#28576
- react/react#28577
- react/react#28571
- react/react#28572
- react/react#28560
- react/react#28569
- react/react#28573
- react/react#28546
- react/react#28568
- react/react#28562
- react/react#28566
- react/react#28565
- react/react#28559
- react/react#28508
- react/react#20432
- react/react#28555
- react/react#24730
- react/react#28472
- react/react#27991
- react/react#28514
- react/react#28548
- react/react#28526
- react/react#28515
- react/react#28533
- react/react#28532
- react/react#28531
- react/react#28407
- react/react#28522
- react/react#28538
- react/react#28509
- react/react#28534
- react/react#28527
- react/react#28528
- react/react#28519
- react/react#28411
- react/react#28520
- react/react#28518
- react/react#28493
- react/react#28504
- react/react#28499
- react/react#28501
- react/react#28496
- react/react#28471
- react/react#28351
- react/react#28486
- react/react#28490
- react/react#28488
- react/react#28468
- react/react#28321
- react/react#28477
- react/react#28479
- react/react#28480
- react/react#28478
- react/react#28464
- react/react#28475
- react/react#28456
- react/react#28319
- react/react#28345
- react/react#28337
- react/react#28335
- react/react#28466
- react/react#28462
- react/react#28322
- react/react#28444
- react/react#28448
- react/react#28449
- react/react#28446
- react/react#28447
- react/react#24580
@yungstersyungsters
mentioned this pull request
Mar 25, 2024
 Merged

yungsters added a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
6fd0cb9
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 26, 2024
@yungsters
CleanupalwaysThrottleDisappearingFallbacksFlag (#28639)
ed3c6af
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for [6fd0cb9](6fd0cb9)
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
AddalwaysThrottleDisappearingFallbacksFlag (react#28550)
6fc81c3
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from react#26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
react#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
EdisonVan pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
@yungsters@AndyPengc12
CleanupalwaysThrottleDisappearingFallbacksFlag (react#28639)
6b71243
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
bigfootjon pushed a commit
that referenced
this pull request
Apr 18, 2024
@yungsters
AddalwaysThrottleDisappearingFallbacksFlag (#28550)
544e688
## Summary
Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that
gates the changes from #26802
(instead of being controlled by `alwaysThrottleRetries`). The values of
this new flag mirror the current values of `alwaysThrottleRetries` such
that there is no behavior difference.
This additional feature flag allows us to incrementally validate the
change (arguably bug fix) from
#26802 independently from
`alwaysThrottleRetries`.
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit 0aab065.
@eps1loneps1lon
mentioned this pull request
Apr 19, 2024
 Merged

Akshato07 pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
@yungsters
Cleanup alwaysThrottleDisappearingFallbacks Flag (#28639)
64cc527
## Summary
After realizing that this feature flag is entangled with
`alwaysThrottleRetries`, we're going to undo
react/react#28550
## How did you test this change?
```
$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric
```
DiffTrain build for commit react/react@6fd0cb9.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rickhanloniirickhanloniirickhanlonii approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@yungsters@react-sizebot@rickhanlonii@facebook-github-bot