[compiler][ez] Clean up duplicate code in propagateScopeDeps by mofeiZ · Pull Request #31581 · react/react

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

mofeiZ · 2024-11-19T14:51:55Z

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Stack created with Sapling. Best reviewed with ReviewStack.

vercel · 2024-11-19T14:51:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 7:10pm

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mvitousek · 2024-12-16T19:21:37Z

+ return;
+ }
+ if (value.kind === 'PropertyLoad') {
+ context.visitProperty(value.object, value.property, false);


Doesn't seem to be a equivalent to the context.isUsedOutsideDeclaringScope(lvalue) check in the new version, is that a semantic change?

Ahh that's because we already check context.isUsedOutsideDeclaringScope when building the temporaries sidemap. It's a bit awkward, but we need this information when constructing the temporaries sidemap because:
context.isUsedOutsideDeclaringScope represents a reordering barrier
the whole point of the temporaries sidemap is to represent reorderable / semantically equivalent expressions
it's difficult to defer finding reordering barriers because they may affect multiple temporaries entries i.e. PropertyLoads from non-reorderable values
I originally duplicated this code to decouple temporary sidemap construction from dependency collection. But.. I think that made maintaining this code much more difficult. @mvitousek I'd love feedback on how to make this cleaner!

…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (react#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761) Enable disableDefaultPropsExceptForClasses (react#31804) Turn on useModernStrictMode in test renderers (react#31769) [compiler][ez] Add shape for global Object.keys (react#31583) [compiler] Context variables as dependencies (react#31582) [compiler] Add fire to known React APIs (react#31795) [compiler] Add option for firing effect functions (react#31794) [compiler][be] Logger based debug printing in test runner (react#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581) [compiler] Repro for aliased captures within inner function expressions (react#31770) [compiler][be] Playground now compiles entire program (react#31774) [Flight] Color and badge non-primary environments (react#31738) [Flight] Emit Deduped Server Components Marker (react#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736) Clean up context access profiling experiment (react#31806) [Flight] Stack Parallel Components in Separate Tracks (react#31735) Flag for requestPaint (react#31805)

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 19, 2024

This was referenced Nov 19, 2024
[compiler] Context variables as dependencies #31582
Merged
[compiler][ez] Add shape for global Object.keys #31583
Merged

vercelBotdeployed to Preview November 19, 2024 14:55 View deployment

[compiler][ez] Clean up duplicate code in propagateScopeDeps
08d6ad7
Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

mofeiZ force-pushed the pr31579 branch from 8fb1dc4 to 08d6ad7Compare December 16, 2024 19:07

vercelBotdeployed to Preview December 16, 2024 19:10 View deployment

mvitousek reviewed Dec 16, 2024
View reviewed changes

josephsavona approved these changes Dec 16, 2024
View reviewed changes

mofeiZ merged commit ac17270 into mainDec 16, 2024

poteto deleted the pr31579 branch March 11, 2025 15:24

Uh oh!

Conversation

mofeiZ commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Uh oh!

vercelBot commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mofeiZ commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Uh oh!

vercelBot commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mofeiZ commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Uh oh!

vercelBot commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mofeiZ commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clean up duplicate checks for when to skip processing values as dependencies / hoistable temporaries.

Uh oh!

vercelBot commented Nov 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading

mofeiZ commented Nov 19, 2024•
edited
Loading

vercelBot commented Nov 19, 2024•
edited
Loading