[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks - #31736

Merged
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort
Dec 16, 2024
Merged

[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks#31736
sebmarkbage merged 1 commit into
react:mainfrom
sebmarkbage:flightsort

Conversation

@sebmarkbage

Copy link
Copy Markdown
Contributor

Stacked on #31735.

This ensures that Server Components Track comes first. Since it's typically rendered first on the server for initial load and then flows into scheduler and client components work. Also puts it closer to the Network and further away from "Main" JS.

Screenshot 2024-12-11 at 5 31 41 PM

Same trick as in #31615.

@vercel

vercelBot commented Dec 11, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
react-compiler-playground✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 16, 2024 5:15pm

@react-sizebot

react-sizebot commented Dec 11, 2024

Copy link
Copy Markdown

Comparing: 031230d2e047c1a354037795a5790ed421d51c55...def6a1125922b72c1b791d079ae30f8961d29a74

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=510.76 kB510.76 kB=91.36 kB91.36 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=515.55 kB515.55 kB=92.17 kB92.17 kB
facebook-www/ReactDOM-prod.classic.js=594.69 kB594.69 kB=104.93 kB104.93 kB
facebook-www/ReactDOM-prod.modern.js=584.96 kB584.96 kB=103.37 kB103.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js+0.41%140.79 kB141.37 kB+0.55%33.04 kB33.23 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js+0.35%100.55 kB100.90 kB+0.46%19.09 kB19.17 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js+0.35%100.67 kB101.02 kB+0.45%19.25 kB19.33 kB
oss-experimental/react-client/cjs/react-client-flight.development.js+0.34%102.00 kB102.35 kB+0.47%18.97 kB19.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js+0.34%102.86 kB103.21 kB+0.46%19.63 kB19.72 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js+0.34%103.16 kB103.51 kB+0.44%19.65 kB19.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js+0.34%103.42 kB103.77 kB+0.45%19.76 kB19.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js+0.33%104.77 kB105.12 kB+0.44%19.97 kB20.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js+0.33%104.96 kB105.31 kB+0.44%19.99 kB20.08 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js+0.33%107.41 kB107.76 kB+0.44%20.44 kB20.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js+0.32%109.16 kB109.51 kB+0.41%20.77 kB20.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js+0.32%109.25 kB109.60 kB+0.41%20.80 kB20.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js+0.32%110.15 kB110.50 kB+0.43%20.70 kB20.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js+0.31%111.49 kB111.84 kB+0.42%20.96 kB21.05 kB

Generated by 🚫 dangerJS against 70facac

@sebmarkbage
sebmarkbage merged commit 07facb5 into react:mainDec 16, 2024
sebmarkbage added a commit that referenced this pull request Dec 16, 2024
Stacked on #31736.
<img width="1223" alt="Screenshot 2024-12-11 at 8 21 12 PM"
src="https://github.com/user-attachments/assets/a7cbc04b-c831-476b-aa2f-baddec9461c9"
/>
This emits a placeholder when we're deduping a component. This starts
when the parent's self time ends, where we would've started rendering
this component if it wasn't already started. The end time is when the
actual render ends since the parent is also blocked by it.
davesnx added a commit to davesnx/react that referenced this pull request Dec 18, 2024
…act into issue-31578-setter-arity-gcc
* 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react:
[flags] Clean up scheduler flags (react#31814)
Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (react#31761)
Enable disableDefaultPropsExceptForClasses (react#31804)
Turn on useModernStrictMode in test renderers (react#31769)
[compiler][ez] Add shape for global Object.keys (react#31583)
[compiler] Context variables as dependencies (react#31582)
[compiler] Add fire to known React APIs (react#31795)
[compiler] Add option for firing effect functions (react#31794)
[compiler][be] Logger based debug printing in test runner (react#31809)
[compiler][ez] Clean up duplicate code in propagateScopeDeps (react#31581)
[compiler] Repro for aliased captures within inner function expressions (react#31770)
[compiler][be] Playground now compiles entire program (react#31774)
[Flight] Color and badge non-primary environments (react#31738)
[Flight] Emit Deduped Server Components Marker (react#31737)
[Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (react#31736)
Clean up context access profiling experiment (react#31806)
[Flight] Stack Parallel Components in Separate Tracks (react#31735)
Flag for requestPaint (react#31805)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedReact Core TeamOpened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage@react-sizebot@eps1lon@facebook-github-bot